Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if shutdown_request can be implemented more gracefully by backends #119

Open
zmughal opened this issue Dec 23, 2024 · 1 comment
Open

Comments

@zmughal
Copy link
Member

zmughal commented Dec 23, 2024

An example of this causing issues is when running PDL::Graphics::Gnuplot which has a line:

https://github.com/PDLPorters/PDL-Graphics-Gnuplot/blob/2.032/lib/PDL/Graphics/Gnuplot.pm#L2102

which dies on various signals. This creates extra messages even in non-interactive settings such as using jupyter nbconvert. It can also be seen with jupyter notebook when terminating kernels manually or shutting down the server.

Docs: https://ipython.org/ipython-doc/dev/development/messaging.html#kernel-shutdown.

@mohawk2
Copy link

mohawk2 commented Dec 30, 2024

This could be handled at least in P:G:Gnuplot by stopping that signal-handling if an environment variable is set, maybe PDL_GRAPHICS_GNUPLOT_NO_SIGHANDLE, which your plugin could set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants