Skip to content
This repository was archived by the owner on Nov 17, 2022. It is now read-only.

Centralise fixtures under iati/tests/fixtures/ #289

Open
hayfield opened this issue Mar 9, 2018 · 0 comments
Open

Centralise fixtures under iati/tests/fixtures/ #289

hayfield opened this issue Mar 9, 2018 · 0 comments
Labels
enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). repo-management Changes relating to management of the repository.

Comments

@hayfield
Copy link
Contributor

hayfield commented Mar 9, 2018

At the moment test fixtures are spread around a number of different test files. This makes them hard to use for multiple purposes - for example, using a fixture that returns an XML string to test both the data and validator modules.

As part of #280, fixtures returning version numbers were centralised in a common location (iati/tests/fixtures/) that can be used across all the test files. This sort of approach should be used for fixtures of all types to make the code clearer, more powerful, and easier to maintain.

@hayfield hayfield added enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). repo-management Changes relating to management of the repository. labels Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Some sort of new functionality (rather than fixing or tweaking something that already existed). repo-management Changes relating to management of the repository.
Projects
None yet
Development

No branches or pull requests

1 participant