Skip to content

Commit 2d7639f

Browse files
committedJan 14, 2024
Fix single dispatch functions
1 parent 9096fab commit 2d7639f

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed
 

‎pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ ignore = [
136136
"ANN101", # Missing type annotation for `self` in method
137137
"ANN102", # Missing type annotation for `cls` in method
138138
"ANN401", # Any-typing allowed
139+
"ARG002", # Unused method argument
139140
"ARG003", # Unused class method argument
140141
"N805", # First argument of a method should be named `self`
141142
"SLF001", # Accessing private members is allowed

‎query_optimizer/fields.py

+11-8
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ def cache_edges(edges: list[EdgeType], info: GQLInfo) -> None:
8383
)
8484

8585

86-
@convert_django_field.register
86+
@convert_django_field.register(models.OneToOneRel)
8787
def convert_reverse_to_one_field_to_django_model(
88-
field: models.OneToOneRel,
88+
field, # noqa: ANN001
8989
registry: Registry | None = None,
9090
) -> graphene.Dynamic:
9191
def dynamic_type() -> graphene.Field | None:
@@ -94,7 +94,7 @@ def dynamic_type() -> graphene.Field | None:
9494
return None
9595

9696
class CustomField(graphene.Field):
97-
def wrap_resolve(self, parent_resolver: Any) -> Any: # noqa: ARG002
97+
def wrap_resolve(self, parent_resolver: Any) -> Any:
9898
def custom_resolver(root: Any, info: GQLInfo) -> models.Model | None:
9999
return _type.get_node(info, root.pk)
100100

@@ -105,9 +105,10 @@ def custom_resolver(root: Any, info: GQLInfo) -> models.Model | None:
105105
return graphene.Dynamic(dynamic_type)
106106

107107

108-
@convert_django_field.register
108+
@convert_django_field.register(models.OneToOneField)
109+
@convert_django_field.register(models.ForeignKey)
109110
def convert_forward_to_one_field_to_django_model(
110-
field: models.OneToOneField | models.ForeignKey,
111+
field, # noqa: ANN001
111112
registry: Registry | None = None,
112113
) -> graphene.Dynamic:
113114
def dynamic_type() -> graphene.Field | None:
@@ -116,7 +117,7 @@ def dynamic_type() -> graphene.Field | None:
116117
return None
117118

118119
class CustomField(graphene.Field):
119-
def wrap_resolve(self, parent_resolver: Any) -> Any: # noqa: ARG002
120+
def wrap_resolve(self, parent_resolver: Any) -> Any:
120121
def custom_resolver(root: Any, info: GQLInfo) -> models.Model | None:
121122
field_name = to_snake_case(info.field_name)
122123
db_field_key: str = root.__class__._meta.get_field(field_name).attname
@@ -133,9 +134,11 @@ def custom_resolver(root: Any, info: GQLInfo) -> models.Model | None:
133134
return graphene.Dynamic(dynamic_type)
134135

135136

136-
@convert_django_field.register
137+
@convert_django_field.register(models.ManyToManyField)
138+
@convert_django_field.register(models.ManyToManyRel)
139+
@convert_django_field.register(models.ManyToOneRel)
137140
def convert_to_many_field_to_list_or_connection(
138-
field: models.ManyToManyField | models.ManyToManyRel | models.ManyToOneRel,
141+
field, # noqa: ANN001
139142
registry: Registry | None = None,
140143
) -> graphene.Dynamic:
141144
def dynamic_type() -> graphene_django.fields.DjangoConnectionField | DjangoListField | None:

0 commit comments

Comments
 (0)