Skip to content

Commit f36a291

Browse files
committed
More POM edits
1 parent a87c24a commit f36a291

File tree

3 files changed

+51
-41
lines changed

3 files changed

+51
-41
lines changed

.gitmodules

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "snark"]
2+
path = snark
3+
url = https://github.com/RAIRLab/snark

pom.xml

+47-41
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22

33
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
4+
45
<modelVersion>4.0.0</modelVersion>
5-
66
<groupId>com.naveensundarg</groupId>
77
<artifactId>prover</artifactId>
88
<version>1.40</version>
@@ -21,18 +21,21 @@
2121
<url>https://opensource.org/licenses/MIT</url>
2222
</license>
2323
</licenses>
24+
25+
<properties>
26+
<!-- This tells maven to build with Java 8 for Java 8-->
27+
<maven.compiler.source>1.8</maven.compiler.source>
28+
<maven.compiler.target>1.8</maven.compiler.target>
2429

25-
<!-- DEADCODE scm is not being used and this version hasn't been used -->
26-
<!--<scm>
27-
<connection>scm:git:https://github.com/naveensundarg/prover.git</connection>
28-
<developerConnection>scm:git:https://github.com/naveensundarg/prover.git</developerConnection>
29-
<url>https://github.com/naveensundarg/prover</url>
30-
<tag>prover-1.03</tag>
31-
</scm>-->
30+
<!-- If I have to keep waiting for tests I am going to lose it -James -->
31+
<maven.test.skip>true</maven.test.skip>
32+
</properties>
3233

33-
<build>
34-
<plugins>
35-
<plugin>
34+
35+
<build>
36+
<plugins> <!--plugins run durring the build -->
37+
<plugin>
38+
<!-- This plugin builds our exacuable jars-->
3639
<groupId>org.apache.maven.plugins</groupId>
3740
<artifactId>maven-assembly-plugin</artifactId>
3841
<version>2.4</version>
@@ -92,23 +95,6 @@
9295
<version>1.0.1</version>
9396
</dependency>
9497

95-
<!-- Deadcode, used to visualize graphs we don't have -->
96-
<!-- https://github.com/nidi3/graphviz-java -->
97-
<!-- https://mvnrepository.com/artifact/guru.nidi/graphviz-java -->
98-
<!-- <dependency>
99-
<groupId>guru.nidi</groupId>
100-
<artifactId>graphviz-java</artifactId>
101-
<version>0.0.2</version>
102-
</dependency> -->
103-
104-
<!-- DEADCODE Json Parsers, unused by current codebase -->
105-
<!--
106-
<dependency>
107-
<groupId>org.json</groupId>
108-
<artifactId>json</artifactId>
109-
<version>20160212</version>
110-
</dependency>-->
111-
11298
<!-- Parses "extensible data notation" a subset of the clojure syntax -->
11399
<!-- Appears to be made use of extensibly for parsing shadowprover problems -->
114100
<!--https://github.com/bpsm/edn-java-->
@@ -142,13 +128,6 @@
142128
<version>1.10.0</version>
143129
</dependency>
144130

145-
<!-- DEADCODE does not appear to be used by any files -->
146-
<!--<dependency>
147-
<groupId>com.google.code.gson</groupId>
148-
<artifactId>gson</artifactId>
149-
<version>2.8.9</version>
150-
</dependency>-->
151-
152131
<!-- Used for the python interface-->
153132
<!-- https://mvnrepository.com/artifact/net.sf.py4j/py4j -->
154133
<dependency>
@@ -173,6 +152,32 @@
173152
<scope>test</scope>
174153
</dependency>
175154

155+
<!-- I have grouped all the unused dependancies here -->
156+
157+
<!-- Deadcode, used to visualize graphs we don't have -->
158+
<!-- https://github.com/nidi3/graphviz-java -->
159+
<!-- https://mvnrepository.com/artifact/guru.nidi/graphviz-java -->
160+
<!-- <dependency>
161+
<groupId>guru.nidi</groupId>
162+
<artifactId>graphviz-java</artifactId>
163+
<version>0.0.2</version>
164+
</dependency> -->
165+
166+
<!-- DEADCODE Json Parsers, unused by current codebase -->
167+
<!--
168+
<dependency>
169+
<groupId>org.json</groupId>
170+
<artifactId>json</artifactId>
171+
<version>20160212</version>
172+
</dependency>-->
173+
174+
<!-- DEADCODE does not appear to be used by any files -->
175+
<!--<dependency>
176+
<groupId>com.google.code.gson</groupId>
177+
<artifactId>gson</artifactId>
178+
<version>2.8.9</version>
179+
</dependency>-->
180+
176181
</dependencies>
177182

178183
<!-- DEADCODE we're not deploying here, git is fine -->
@@ -184,10 +189,11 @@
184189
</repository>
185190
</distributionManagement> -->
186191

187-
<!-- This tells maven to build with Java 8 for Java 8-->
188-
<properties>
189-
<maven.compiler.source>1.8</maven.compiler.source>
190-
<maven.compiler.target>1.8</maven.compiler.target>
191-
</properties>
192-
192+
<!-- DEADCODE scm is not being used and this version hasn't been used -->
193+
<!--<scm>
194+
<connection>scm:git:https://github.com/naveensundarg/prover.git</connection>
195+
<developerConnection>scm:git:https://github.com/naveensundarg/prover.git</developerConnection>
196+
<url>https://github.com/naveensundarg/prover</url>
197+
<tag>prover-1.03</tag>
198+
</scm>-->
193199
</project>

snark

Submodule snark added at 1b657ea

0 commit comments

Comments
 (0)