Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Commit 378a933

Browse files
committed
fix(progressbar): number filter in bar template and only for percent
Closes #1807
1 parent e199349 commit 378a933

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

src/progressbar/test/progressbar.spec.js

-2
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,6 @@ describe('progressbar directive', function () {
8181

8282
var bar = getBar(0);
8383
expect(bar.css('width')).toBe('50.34%');
84-
85-
expect(bar.attr('aria-valuenow')).toBe('50');
8684
expect(bar.attr('aria-valuetext')).toBe('50%');
8785
});
8886

template/progressbar/bar.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div class="progress-bar" ng-class="type && 'progress-bar-' + type" role="progressbar" aria-valuenow="{{value}}" aria-valuemin="0" aria-valuemax="{{max}}" ng-style="{width: percent + '%'}" aria-valuetext="{{percent}}%" ng-transclude></div>
1+
<div class="progress-bar" ng-class="type && 'progress-bar-' + type" role="progressbar" aria-valuenow="{{value}}" aria-valuemin="0" aria-valuemax="{{max}}" ng-style="{width: percent + '%'}" aria-valuetext="{{percent | number:0}}%" ng-transclude></div>

template/progressbar/progressbar.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
<div class="progress">
2-
<div class="progress-bar" ng-class="type && 'progress-bar-' + type" role="progressbar" aria-valuenow="{{value | number:0}}" aria-valuemin="0" aria-valuemax="{{max}}" ng-style="{width: percent + '%'}" aria-valuetext="{{percent | number:0}}%" ng-transclude></div>
2+
<div class="progress-bar" ng-class="type && 'progress-bar-' + type" role="progressbar" aria-valuenow="{{value}}" aria-valuemin="0" aria-valuemax="{{max}}" ng-style="{width: percent + '%'}" aria-valuetext="{{percent | number:0}}%" ng-transclude></div>
33
</div>

0 commit comments

Comments
 (0)