Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ansible/ansible-hub-ui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1d8f20c5c63353c9e23e5a5742a368eb53d92a05
Choose a base ref
..
head repository: ansible/ansible-hub-ui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 00033111c2e2cb48f8f98c6e0b16955e9f435722
Choose a head ref
Showing with 28 additions and 20 deletions.
  1. +1 −0 CHANGES/5415.bug
  2. +1 −0 CHANGES/5416.bug
  3. +1 −0 CHANGES/5417.bug
  4. +9 −9 package-lock.json
  5. +2 −2 package.json
  6. +3 −1 src/components/render-plugin-doc.scss
  7. +5 −3 src/components/render-plugin-doc.tsx
  8. +5 −4 test/package-lock.json
  9. +1 −1 test/package.json
1 change: 1 addition & 0 deletions CHANGES/5415.bug
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Collection documentation: treat options of type `boolean` the same as options of type `bool`.
1 change: 1 addition & 0 deletions CHANGES/5416.bug
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Collection documentation: process markup in deprecation messages.
1 change: 1 addition & 0 deletions CHANGES/5417.bug
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Collection documentation: fix zero width of spacer columns indenting suboptions and sub-return values.
18 changes: 9 additions & 9 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -10,8 +10,8 @@
"@lingui/react": "^5.0.0",
"@patternfly/patternfly": "^5.4.2",
"@patternfly/react-code-editor": "^5.4.0",
"@patternfly/react-core": "^5.4.13",
"@patternfly/react-table": "^5.4.15",
"@patternfly/react-core": "^5.4.14",
"@patternfly/react-table": "^5.4.16",
"@redhat-cloud-services/frontend-components": "^4.2.16",
"antsibull-docs": "^1.1.0",
"axios": "^1.7.7",
4 changes: 3 additions & 1 deletion src/components/render-plugin-doc.scss
View file
Original file line number Diff line number Diff line change
@@ -21,7 +21,9 @@
width: 100%;

.spacer {
width: 20px;
// The !important is needed here to avoid the value being overridden
// by table.css injected by some dependencies.
width: 20px !important;
border-top: 0;
border-bottom: 0;
}
8 changes: 5 additions & 3 deletions src/components/render-plugin-doc.tsx
View file
Original file line number Diff line number Diff line change
@@ -429,13 +429,15 @@ export class RenderPluginDoc extends Component<IProps, IState> {

<div>
<b>{t`Why:`}</b>{' '}
{deprecated.why ? doc.deprecated.why : t`No reason specified.`}
{deprecated.why
? this.applyDocFormatters(doc.deprecated.why)
: t`No reason specified.`}
</div>

<div>
<b>{t`Alternative:`}</b>{' '}
{deprecated.alternative
? doc.deprecated.alternative
? this.applyDocFormatters(doc.deprecated.alternative)
: t`No alternatives specified.`}
</div>
</>
@@ -692,7 +694,7 @@ export class RenderPluginDoc extends Component<IProps, IState> {
defaultChoice,
legends = {};

if (option['type'] === 'bool') {
if (option['type'] === 'bool' || option['type'] === 'boolean') {
choices = ['true', 'false'];

if (option['default'] === true) {
9 changes: 5 additions & 4 deletions test/package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/package.json
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
"cypress": "cypress open"
},
"dependencies": {
"chrome-remote-interface": "^0.33.2",
"chrome-remote-interface": "^0.33.3",
"cypress": "^13.16.1",
"cypress-file-upload": "^5.0.8",
"shell-escape-tag": "^2.0.2",