Pass user info to workflow

Author: jraddaoui

internal/storage/deletion_request.go

@@ -6,10 +6,26 @@ import (
 
 	"github.com/google/uuid"
 
+	"github.com/artefactual-sdps/enduro/internal/api/auth"
 	goastorage "github.com/artefactual-sdps/enduro/internal/api/gen/storage"
 )
 
 func (s *serviceImpl) RequestAipDeletion(ctx context.Context, payload *goastorage.RequestAipDeletionPayload) error {
+	// Authentication must be enabled for now.
+	claims := auth.UserClaimsFromContext(ctx)
+	if claims == nil {
+		return goastorage.MakeNotValid(errors.New("authentication is required"))
+	}
+	if claims.Email == "" {
+		return goastorage.MakeNotValid(errors.New("email claim is required"))
+	}
+	if claims.Sub == "" {
+		return goastorage.MakeNotValid(errors.New("sub claim is required"))
+	}
+	if claims.ISS == "" {
+		return goastorage.MakeNotValid(errors.New("iss claim is required"))
+	}
+
 	aipID, err := uuid.Parse(payload.UUID)
 	if err != nil {
 		return goastorage.MakeNotValid(errors.New("invalid UUID"))
@@ -18,17 +34,15 @@ func (s *serviceImpl) RequestAipDeletion(ctx context.Context, payload *goastorag
 		return goastorage.MakeNotValid(errors.New("invalid reason"))
 	}
 
-	// TODO:
-	// - Check AIP existence and status, same as in workflow.
-	// - Get user details from context claim and include them in the request.
+	// TODO: Check AIP existence and status, same as in workflow.
 
 	_, err = InitStorageDeleteWorkflow(ctx, s.tc, &StorageDeleteWorkflowRequest{
 		AIPID:     aipID,
 		Reason:    payload.Reason,
 		TaskQueue: s.config.TaskQueue,
-		UserEmail: "",
-		UserSub:   "",
-		UserISS:   "",
+		UserEmail: claims.Email,
+		UserSub:   claims.Sub,
+		UserISS:   claims.ISS,
 	})
 	if err != nil {
 		s.logger.Error(err, "error initializing delete workflow")
@@ -39,20 +53,33 @@ func (s *serviceImpl) RequestAipDeletion(ctx context.Context, payload *goastorag
 }
 
 func (s *serviceImpl) ReviewAipDeletion(ctx context.Context, payload *goastorage.ReviewAipDeletionPayload) error {
+	// Authentication must be enabled for now.
+	claims := auth.UserClaimsFromContext(ctx)
+	if claims == nil {
+		return goastorage.MakeNotValid(errors.New("authentication is required"))
+	}
+	if claims.Email == "" {
+		return goastorage.MakeNotValid(errors.New("email claim is required"))
+	}
+	if claims.Sub == "" {
+		return goastorage.MakeNotValid(errors.New("sub claim is required"))
+	}
+	if claims.ISS == "" {
+		return goastorage.MakeNotValid(errors.New("iss claim is required"))
+	}
+
 	aipID, err := uuid.Parse(payload.UUID)
 	if err != nil {
 		return goastorage.MakeNotValid(errors.New("invalid UUID"))
 	}
 
-	// TODO:
-	// - Check AIP existence and status, and DeletionRequest.
-	// - Get user details from context claim and include them in the signal.
+	// TODO: Check AIP existence and status, and DeletionRequest.
 
 	signal := DeletionReviewedSignal{
 		Approved:  payload.Approved,
-		UserEmail: "",
-		UserSub:   "",
-		UserISS:   "",
+		UserEmail: claims.Email,
+		UserSub:   claims.Sub,
+		UserISS:   claims.ISS,
 	}
 	err = s.tc.SignalWorkflow(ctx, StorageDeleteWorkflowID(aipID), "", DeletionReviewedSignalName, signal)
 	if err != nil {