Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps mds.js should in some way handle numeric.js exceptions #1

Open
bertvandepoel opened this issue Aug 11, 2020 · 0 comments
Open

Comments

@bertvandepoel
Copy link

I just hit a case where after 50 iterations, the SVD still hasn't converged in numeric.js. This results in an exception being thrown https://github.com/sloisel/numeric/blob/master/src/svd.js#L212

I know you're probably not expecting many people to be using this, but mds.js saved me from gonum dependency hell, so I'm quite happy with it. So first of all I'm not sure if you even want issues and/or PRs. Second, I'm not sure if mds.js should handle these exceptions in some way or not. I guess it should at least indicate to potential users they might need to catch and handle that exception?

Feel free to ignore this if you don't feel like it. I just thought I'd do my fair share and at least let you know about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant