Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolate env vars that look like integers as Python integers. #148

Closed
ghost opened this issue Jun 10, 2016 · 3 comments
Closed

Interpolate env vars that look like integers as Python integers. #148

ghost opened this issue Jun 10, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Jun 10, 2016

Discussion was started here: #144 (comment)

my initial ask:

p.s. rather than opening another issue immediately, another quick question: Is it possible to source integers from environment variables in the YAML? I ask because I just tried to source poll delay and count from environ, but test failed complaining about strings vs. integers. I tried unquoting the value during shell export, but no dice. Worth opening a new issue?

@cdent's reponse from #144:

The issue with strings and ints is because environment variables are always strings, see this block of code. In that block it would be possible to turn things that look like ints into its.
However, poll and count, don't use substitutions so even if the environment was producing stuff it wouldn't get pulled, so some fixes would be needed in the poll handling.
Yeah, if you could make a fresh issue, that would be great.

@cdent Please let me know if you meant to create a fresh issue for the poll/count substitutions and not for this. If so, I'll close this issue and open one on that.

@cdent
Copy link
Owner

cdent commented Jun 10, 2016

I meant poll/count substitutions, sorry for being unclear, but let's leave this one here too, so we can track that as well. There's a similar problem (to this one) in #147. So there's a slew of "type" issues that need some thought at the overall level, not just the specific instance level. Having a few different issues going helps (at least it helps me) indicate the breadth of the high level issue.

@ghost
Copy link
Author

ghost commented Jun 10, 2016

Sounds good. Opened #150 for poll and count substitutions.

@cdent
Copy link
Owner

cdent commented Jul 13, 2016

I think we can close this one based on the explorations in #161 which suggest that how the interpolation happens is a bit context dependent. Please reopen or create another one if there are additional details which suggest otherwise.

@cdent cdent closed this as completed Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant