Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Display bugs introduced by #175 #191

Closed
codeofmochi opened this issue Sep 21, 2021 · 0 comments
Closed

Display bugs introduced by #175 #191

codeofmochi opened this issue Sep 21, 2021 · 0 comments
Assignees
@s314cy
Labels
bug Something isn't working

Comments

@codeofmochi
Copy link
Collaborator

codeofmochi commented Sep 21, 2021 •
edited
Loading

#175 introduced 2 display bugs:

  1. Responsive design of menu bar is broken with the new events tab (noticeable at ~1680px, 1442px). I think the menu bar is getting too crowded anyway, we should think of a hierarchy of menu + submenus rather than trying to fit everything in there.
ezgif.com-gif-maker.mp4
  1. The menu style for the current tab is not applied to the events page.

clicmenu

This is caused by the following LOC:
https://github.com/clicepfl/clic-website/blob/63b777831606f78455d3a4e70563074b6686deff/src/pages/events/events-page-view.njk#L21

The page parameter does not exist, it should be tab instead:

- {{ base.header(page = "events") }}
+ {{ base.header(tab = "events") }}

Related to #141
@codeofmochi codeofmochi added the bug Something isn't working label Sep 21, 2021
s314cy added a commit that referenced this issue Sep 22, 2021
@s314cy
fix events current tab #191
969c259
s314cy added a commit that referenced this issue Sep 22, 2021
@s314cy
move poles to /about, resize menu #174 #191
91a2a3e
@s314cy s314cy closed this as completed Sep 22, 2021
clicepfl pushed a commit that referenced this issue Sep 22, 2021
@s314cy
Fix event current tab display (#195)
efe03f5 
* nc calendar displays correctly #52

* events page ready #52

* icbd href fix #52

* remove old icbd page copies #52

* fix calendar link & menu display #52

* testing other calendar #52

* title change #52

* fix events current tab #191

Co-authored-by: CLIC EPFL <48416147+clicepfl@users.noreply.github.com>
clicepfl pushed a commit that referenced this issue Sep 22, 2021
@s314cy
move poles to /about, resize menu #174 #191 (#194)
d0b7ed8 
Co-authored-by: CLIC EPFL <48416147+clicepfl@users.noreply.github.com>
clicepfl pushed a commit that referenced this issue Oct 20, 2021
@s314cy
Events component & better event display (#202)
5248068 
* nc calendar displays correctly #52

* events page ready #52

* icbd href fix #52

* remove old icbd page copies #52

* fix calendar link & menu display #52

* testing other calendar #52

* title change #52

* fix events current tab #191

* betterify the events page #52

* better events page wip #52

* wip #52]

* ready for prod #52

Co-authored-by: CLIC EPFL <48416147+clicepfl@users.noreply.github.com>
clicepfl pushed a commit that referenced this issue Oct 21, 2021
@s314cy
Minor fixes to /events (#205)
0c69b26 
* nc calendar displays correctly #52

* events page ready #52

* icbd href fix #52

* remove old icbd page copies #52

* fix calendar link & menu display #52

* testing other calendar #52

* title change #52

* fix events current tab #191

* betterify the events page #52

* better events page wip #52

* wip #52]

* ready for prod #52

* few fixes #52

Co-authored-by: CLIC EPFL <48416147+clicepfl@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@s314cy s314cy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeofmochi @s314cy