Skip to content

Commit c16e209

Browse files
author
Bernhard Grünewaldt
committed
hide loading animation when image is loaded
1 parent 5a77414 commit c16e209

6 files changed

+27
-2
lines changed

build/cc-image-lightbox.css

+3
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,9 @@
7070
background: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMzIiIGhlaWdodD0iMzIiIHZpZXdCb3g9IjAgMCA0NCA0NCIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiBzdHJva2U9IiNmZmYiPgogICAgPGcgZmlsbD0ibm9uZSIgZmlsbC1ydWxlPSJldmVub2RkIiBzdHJva2Utd2lkdGg9IjIiPgogICAgICAgIDxjaXJjbGUgY3g9IjIyIiBjeT0iMjIiIHI9IjEiPgogICAgICAgICAgICA8YW5pbWF0ZSBhdHRyaWJ1dGVOYW1lPSJyIiBiZWdpbj0iMHMiIGR1cj0iMS44cyIgdmFsdWVzPSIxOyAyMCIgY2FsY01vZGU9InNwbGluZSIga2V5VGltZXM9IjA7IDEiIGtleVNwbGluZXM9IjAuMTY1LCAwLjg0LCAwLjQ0LCAxIiByZXBlYXRDb3VudD0iaW5kZWZpbml0ZSIvPgogICAgICAgICAgICA8YW5pbWF0ZSBhdHRyaWJ1dGVOYW1lPSJzdHJva2Utb3BhY2l0eSIgYmVnaW49IjBzIiBkdXI9IjEuOHMiIHZhbHVlcz0iMTsgMCIgY2FsY01vZGU9InNwbGluZSIga2V5VGltZXM9IjA7IDEiIGtleVNwbGluZXM9IjAuMywgMC42MSwgMC4zNTUsIDEiIHJlcGVhdENvdW50PSJpbmRlZmluaXRlIi8+CiAgICAgICAgPC9jaXJjbGU+CiAgICAgICAgPGNpcmNsZSBjeD0iMjIiIGN5PSIyMiIgcj0iMSI+CiAgICAgICAgICAgIDxhbmltYXRlIGF0dHJpYnV0ZU5hbWU9InIiIGJlZ2luPSItMC45cyIgZHVyPSIxLjhzIiB2YWx1ZXM9IjE7IDIwIiBjYWxjTW9kZT0ic3BsaW5lIiBrZXlUaW1lcz0iMDsgMSIga2V5U3BsaW5lcz0iMC4xNjUsIDAuODQsIDAuNDQsIDEiIHJlcGVhdENvdW50PSJpbmRlZmluaXRlIi8+CiAgICAgICAgICAgIDxhbmltYXRlIGF0dHJpYnV0ZU5hbWU9InN0cm9rZS1vcGFjaXR5IiBiZWdpbj0iLTAuOXMiIGR1cj0iMS44cyIgdmFsdWVzPSIxOyAwIiBjYWxjTW9kZT0ic3BsaW5lIiBrZXlUaW1lcz0iMDsgMSIga2V5U3BsaW5lcz0iMC4zLCAwLjYxLCAwLjM1NSwgMSIgcmVwZWF0Q291bnQ9ImluZGVmaW5pdGUiLz4KICAgICAgICA8L2NpcmNsZT4KICAgIDwvZz4KPC9zdmc+) center center no-repeat;
7171
background-size:4rem;
7272
}
73+
.cc-lightbox--image-loaded {
74+
background: transparent;
75+
}
7376
.cc-lightbox--image-inner {
7477
height:100%;
7578
width: 100%;

build/cc-image-lightbox.js

+10
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,11 @@ var CCImageLightbox = function () {
154154
}
155155
return button;
156156
}
157+
}, {
158+
key: '_generateId',
159+
value: function _generateId(galleryId, index) {
160+
return 'cc-lightbox--' + galleryId + '--' + index;
161+
}
157162
}, {
158163
key: 'closeIfOpen',
159164
value: function closeIfOpen() {
@@ -216,12 +221,17 @@ var CCImageLightbox = function () {
216221
imageInnerWrap.setAttribute('class', 'cc-lightbox--image-inner-wrap');
217222
imageInner.appendChild(imageInnerWrap);
218223
var img = document.createElement('img');
224+
img.onload = function () {
225+
image.setAttribute('class', 'cc-lightbox--image cc-lightbox--image-loaded');
226+
};
219227
img.setAttribute('src', self._getImage(galleryId, index).src);
220228
img.setAttribute('class', 'cc-lightbox--image-img');
229+
img.setAttribute('id', self._generateId(galleryId, index));
221230
imageInnerWrap.appendChild(img);
222231

223232
// NEXT BUTTON
224233
wrapper.appendChild(self._renderNextOrPreviousButton(galleryId, indexInt + 1, 'right'));
234+
225235
return false;
226236
}
227237
}, {

build/cc-image-lightbox.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)