Flake8 linting

Author: dalager

.github/workflows/pylint.yml

@@ -1,39 +1,35 @@
-# This workflow will install Python dependencies, run tests and lint with a single version of Python
-# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python
-
-name: Python application
+name: Lint and Test
 
 on:
   push:
-    branches: [ "main" ]
+    branches: ["main"]
   pull_request:
-    branches: [ "main" ]
+    branches: ["main"]
 
 permissions:
   contents: read
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v4
-    - name: Set up Python 3.12
-      uses: actions/setup-python@v3
-      with:
-        python-version: "3.12"
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        pip install flake8 pytest
-        if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-    - name: Lint with flake8
-      run: |
-        # stop the build if there are Python syntax errors or undefined names
-        flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-        # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
-        flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
-    - name: Test with pytest
-      run: |
-        pytest 
+      - uses: actions/checkout@v4
+      - name: Set up Python 3.12
+        uses: actions/setup-python@v3
+        with:
+          python-version: "3.12"
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install flake8 pytest
+          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
+      - name: Lint with flake8
+        run: |
+          # stop the build if there are Python syntax errors or undefined names
+          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
+          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+          flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
+      - name: Test with pytest
+        run: |
+          pytest

.github/workflows/python-app.yml

@@ -11,7 +11,7 @@
 # Regular expression to detect cell references like A1, B2, or ranges like A1:B2
 
 # ignore linting error for regex pattern
-CELL_REF_REGEX = r"('?[A-Za-z0-9_\-\[\] ]+'?![A-Z]{1,3}[0-9]+(:[A-Z]{1,3}[0-9]+)?)|([A-Z]{1,3}[0-9]+(:[A-Z]{1,3}[0-9]+)?)"  # pylint: disable=line-too-long
+CELL_REF_REGEX = r"('?[A-Za-z0-9_\-\[\] ]+'?![A-Z]{1,3}[0-9]+(:[A-Z]{1,3}[0-9]+)?)|([A-Z]{1,3}[0-9]+(:[A-Z]{1,3}[0-9]+)?)"
 
 
 def extract_formulas_and_build_dependencies(file_path):
@@ -26,7 +26,7 @@ def extract_formulas_and_build_dependencies(file_path):
     graph = nx.DiGraph()
 
     # Iterate over all sheets
-    for sheet_name in wb.sheetnames:  # pylint: disable=too-many-nested-blocks
+    for sheet_name in wb.sheetnames:
         ws = wb[sheet_name]
         print(f"-- Analyzing sheet: {sheet_name} --")
 
@@ -121,7 +121,7 @@ def visualize_dependency_graph(graph, file_path):
 
 
 if __name__ == "__main__":
-    path_to_excel = "Book1.xlsx"  # pylint: disable=invalid-name
+    path_to_excel = "Book1.xlsx"
 
     # override with command line argument
     import sys

graphbuilder.py

@@ -4,6 +4,7 @@ contourpy==1.3.0
 cycler==0.12.1
 dill==0.3.8
 et-xmlfile==1.1.0
+flake8==7.1.1
 fonttools==4.53.1
 iniconfig==2.0.0
 isort==5.13.2
@@ -17,7 +18,8 @@ packaging==24.1
 pillow==10.4.0
 platformdirs==4.3.3
 pluggy==1.5.0
-pylint==3.2.7
+pycodestyle==2.12.1
+pyflakes==3.2.0
 pyparsing==3.1.4
 pytest==8.3.3
 python-dateutil==2.9.0.post0