Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose SCTs in cleaner fashion #105

Open
machow opened this issue Jun 2, 2017 · 2 comments
Open

expose SCTs in cleaner fashion #105

machow opened this issue Jun 2, 2017 · 2 comments

Comments

@machow
Copy link
Contributor

machow commented Jun 2, 2017

We're doing this little song and dance right now.

from sqlwhat.checks.check_result import check_result, test_has_columns, test_nrows, test_ncols, test_column, allow_error, test_error, test_name_miscased, test_column_name
from sqlwhat.checks.check_logic import fail, multi, extend, test_or, test_correct
from sqlwhat.checks.check_funcs import check_node, check_field, test_student_typed, has_equal_ast, test_mc, success_msg, verify_ast_parses

Should be easier to just define a variable __all__ on each individual module

@filipsch
Copy link
Contributor

I thinks it's beautiful ;) Very minor imo.

@machow
Copy link
Contributor Author

machow commented Jun 19, 2017

The current form does have the advantage of making very clear where each SCT is coming from! We could always just have each import statement span multiple lines, rather than one super long one :p.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants