Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/gyp-next
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: desktop-app/gyp-next
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 25, 2021

  1. Fixed sorting of ProjectRefs when generating project files for xcode.

    @23rd
    23rd committed Oct 25, 2021

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    wraithgar Gar
    GPG key ID: A76652216DC51B79
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    92d4b62 View commit details

Commits on Sep 28, 2022

  1. Fixed casting of remapped element list in MSVC emulation.

    @23rd
    23rd committed Sep 28, 2022
    Copy the full SHA
    4c4f211 View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 pylib/gyp/msvs_emulation.py
  2. +1 −1 pylib/gyp/xcodeproj_file.py
2 changes: 1 addition & 1 deletion pylib/gyp/msvs_emulation.py
View file
Original file line number Diff line number Diff line change
@@ -106,7 +106,7 @@ def _DoRemapping(element, map):
if not callable(map):
map = map.get # Assume it's a dict, otherwise a callable to do the remap.
if isinstance(element, list) or isinstance(element, tuple):
element = filter(None, [map(elem) for elem in element])
element = list(filter(None, [map(elem) for elem in element]))
else:
element = map(element)
return element
2 changes: 1 addition & 1 deletion pylib/gyp/xcodeproj_file.py
View file
Original file line number Diff line number Diff line change
@@ -2990,7 +2990,7 @@ def AddOrGetProjectReference(self, other_pbxproject):
# Xcode seems to sort this list case-insensitively
self._properties["projectReferences"] = sorted(
self._properties["projectReferences"],
key=lambda x: x["ProjectRef"].Name().lower
key=lambda x: x["ProjectRef"].Name().lower()
)
else:
# The link already exists. Pull out the relevnt data.