Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve zones.json for deployment #43

Open
jamesmontemagno opened this issue Jul 31, 2024 · 0 comments
Open

Improve zones.json for deployment #43

jamesmontemagno opened this issue Jul 31, 2024 · 0 comments

Comments

@jamesmontemagno
Copy link
Contributor

This right now doesn't work with www/zones.json in deployment.

We have api code to call out there and get the zones, this is what you need to do right now.

zones.json should be an embedded resource most likely.
jongalloway added a commit that referenced this issue Feb 21, 2025
@jongalloway
Improve zones.json for deployment
df00069 
Fixes #43

Embed `zones.json` as a resource and modify code to read it.

* **Api.csproj**
  - Add `zones.json` as an embedded resource.

* **NwsManager.cs**
  - Modify `GetZonesAsync` method to read `zones.json` as an embedded resource instead of from the `wwwroot` folder.
  - Remove the `webHostEnvironment` parameter from the `NwsManager` constructor.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotnet-presentations/dotnet-aspire-workshop/issues/43?shareId=XXXX-XXXX-XXXX-XXXX).
@jongalloway jongalloway mentioned this issue Feb 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve zones.json for deployment dotnet-presentations/dotnet-aspire-workshop
1 participant
@jamesmontemagno