Bugfix for the BTC-E exchange

Author: Ruben Callewaert

apps/backtester.js

@@ -36,7 +36,7 @@ Util.inherits(backtester, EventEmitter);
 
 backtester.prototype.run = function() {
 
-  advisor.setIndicator(this.indicatorSettings, false);
+  advisor.setIndicator(this.indicatorSettings);
 
   async.series(
       {

exchanges/btce.js

@@ -126,7 +126,7 @@ exchange.prototype.getBalance = function(retry, cb) {
 
       if(!err) {
 
-        cb(null, {assetAvailable: response.funds[asset], currencyAvailable: response.funds[currency], fee: 0.2});
+        cb(null, {assetAvailable: response.return.funds[asset], currencyAvailable: response.return.funds[currency], fee: 0.2});
 
       } else {
 
@@ -196,13 +196,13 @@ exchange.prototype.placeOrder = function(type, amount, price, retry, cb) {
 
         var status = 'open';
 
-        if(response.order_id === 0) {
+        if(response.return.order_id === 0) {
 
           status = 'filled';
 
         }
 
-        cb(null, {txid: response.order_id, status: status});
+        cb(null, {txid: response.return.order_id, status: status});
 
       } else {
 
@@ -242,7 +242,7 @@ exchange.prototype.orderFilled = function(order, retry, cb) {
 
       if(!err) {
 
-        if(response[order]) {
+        if(response.return[order]) {
 
           cb(null, false);
 
@@ -282,7 +282,7 @@ exchange.prototype.cancelOrder = function(order, retry, cb) {
 
           if(!err) {
 
-            if(response.order_id === order) {
+            if(response.return.order_id === order) {
               cb(null, true);
             } else {
               cb(null, false);

services/tradingadvisor.js

@@ -59,7 +59,9 @@ advisor.prototype.start = function() {
 
 		}
 
-		this.emit('advice', this.latestTradeAdvice );
+		if(['buy', 'sell'].indexOf(this.latestTradeAdvice) >= 0) {
+			this.emit('advice', this.latestTradeAdvice);
+		}
 
 	}.bind(this));
 
@@ -86,16 +88,10 @@ advisor.prototype.setPosition = function(pos) {
 
 };
 
-advisor.prototype.setIndicator = function(indicatorSettings, updateIndicator) {
+advisor.prototype.setIndicator = function(indicatorSettings) {
 
 	this.selectedIndicator = new this.indicators[indicatorSettings.indicator](indicatorSettings.options);
 
-	if(updateIndicator) {
-
-		this.start();
-
-	}
-
 };
 
 module.exports = advisor;