Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter PHPStan levels #669

Open
eucyt opened this issue Mar 11, 2025 · 0 comments
Open

Stricter PHPStan levels #669

eucyt opened this issue Mar 11, 2025 · 0 comments
Assignees
@eucyt
Labels
enhancement keep

Comments

@eucyt
Copy link
Contributor

eucyt commented Mar 11, 2025

PHPStan allows you to choose the type of warnings based on levels.
https://phpstan.org/user-guide/rule-levels

It is currently set to level 5 (the maximum is 10). Let's make it stricter and refactor the code for better quality.
@eucyt eucyt self-assigned this Mar 11, 2025
@eucyt eucyt mentioned this issue Mar 12, 2025
Merged
eucyt added a commit that referenced this issue Mar 13, 2025
@eucyt
Stricter PHPStan level to 8 (#671)

Unverified

No user is associated with the committer email.
Learn about vigilant mode
Loading
Loading status checks…
bd10dea 
Related #669 

PHPStan (static code analysis) allows you to choose the type of warnings
based on levels.
https://phpstan.org/user-guide/rule-levels

It is currently set to level 5 (the maximum is 10). Let's make it
stricter and refactor the code for better quality.

I've raised it to level 8 in this PR for now.
@eucyt eucyt added the keep label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eucyt eucyt

Labels
enhancement keep
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eucyt