Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we have a duplicate check for upload? #2

Open
mokko opened this issue Feb 29, 2024 · 2 comments
Open

Do we have a duplicate check for upload? #2

mokko opened this issue Feb 29, 2024 · 2 comments

Comments

@mokko
Copy link
Owner

mokko commented Feb 29, 2024

I was just contemplating how to upload ca. ~10.000 *.tif files from AmArch archive folder. Several identical files (identically named files) exist. I.e. the same file exists in multiple folders. Do we check in uploadAsset for this case or would we upload the same file multiple times.

TODO:

  • Check if that is the case
  • Write such a check if necessary.
@mokko
Copy link
Owner Author

mokko commented Mar 1, 2024

ATM xls.path_exists() has a deduplicating effect since it tests if filename with the same name (not fullpath) has already been entered in the Excel list. We could change that to receive a more exact representation of the files in the directory, but then we would need to check for duplications in the Excel list in the same way we do now, i.e. by identity with filename.

@mokko
Copy link
Owner Author

mokko commented Mar 1, 2024

In the name of "explicit is better than implicit" that might be an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant