-
Notifications
You must be signed in to change notification settings - Fork 512
Olmo's workflow
ibolmo edited this page Nov 29, 2011
·
4 revisions
- Find an issue.
-
git fetch mootools
to get any new changes to master -
git checkout -b [action]-[issue#]-[description-delimited-by-dash]
e.g.git checkout -b fix-1000-ie-button-type-throws
- repeat 2-3 for any submodules
- if necessary, add specs to reproduce failure
- work on the fix^1
- run the specs^2 until all browsers pass
-
git add [files]
orgit commit -a
if modified already present files - write a good commit message^3
-
git push [your-git-repo] [action]-[issue#]-[description-delimited-by-dash]
(tip: use tab completion for topic branch) - go to your github repo page
- select your topic branch
- send pull request. optionally modify subject and description of pull request.
- done, or start over at 1.
^1: Working on the Fix
-
Stick to what you need to fix. If you find something else that needs to be fixed or cleaned, create an issue or create another topic branch.
-
If you're going to fix it with something controversial or something you're unsure of, then commit early and send a pull request with description and with @requests to notify developers.
^2: Running the specs 1.
^3: Write a good commit message