Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep "Set of" naming consistent #118

Open
kodawah opened this issue Dec 12, 2023 · 4 comments
Open

keep "Set of" naming consistent #118

kodawah opened this issue Dec 12, 2023 · 4 comments
Labels
data issue Error with raw data

Comments

@kodawah
Copy link
Contributor

kodawah commented Dec 12, 2023

we need to avoid separating the "set of" with a dash and to always use number instead of spelling things out, and make sure to use "Deck Set" as a tag

The Lost Caverns of Ixalan Commander Deck Set of Four 
Doctor Who Commander Decks Set of Four


Streets of New Capenna Commander Decks - Set of 5 
Innistrad Midnight Hunt Commander Decks - Set of 2 
March of the Machine Commander Decks - Set of 5


The Lost Caverns of Ixalan Commander Deck Set of Four 

are the entries that need a fix

@axxroytovu axxroytovu added the data issue Error with raw data label Dec 12, 2023
@kodawah
Copy link
Contributor Author

kodawah commented Dec 12, 2023

tangential, what do you think about keeping "Box Set" as standard, regardless of number of boxes?

example "The Lord of the Rings Tales of Middle earth Scene Boxes Set of 4" -> "The Lord of the Rings Tales of Middle earth Scene Box Set of 4",

@axxroytovu
Copy link
Collaborator

I think that's a bigger question. I've been keeping the plural "s" in Set of X products because it reads better:

  • Lost Caverns of Ixalan Commander Decks Set of 4
  • Ravnica Theme Decks Set of 5
  • Strixhaven Prerelease Kits Set of 5

And so specifically those products are called "Scene Box" and there is a set of them, so "Scene Boxes".

Do we remove the plural across the board? I personally prefer having the plural.

@kodawah
Copy link
Contributor Author

kodawah commented Dec 12, 2023

I'm not native so some of the nuance may be lost, but I think we decided that the product name should contain the category, and that category is "Scene Box" or "Deck Set" regardless of the amount -- it would simplify the parsing for new names for sure

@axxroytovu
Copy link
Collaborator

Yeah I think this is a confusion of human readable vs machine readable. I personally think that the product name should be designed to be easily readable by a human, even if that makes the computer parsing more complex. That's why we have all of the categories and subcategories, to allow the computer to parse and sort on categoric inputs that aren't a text string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data issue Error with raw data
Projects
None yet
Development

No branches or pull requests

2 participants