RelationalQueryableExtensions.ExecuteDeleteAsync method not found

[rofr]

Which version of Duende IdentityServer are you using?
7.1.0

Which version of .NET are you using?
8.0

Describe the bug
Token cleanup fails with an exception, probably due to some incompatible package references.

Exception removing expired grants: Method not found: 'System.Threading.Tasks.Task1<Int32> Microsoft.EntityFrameworkCore.RelationalQueryableExtensions.ExecuteDeleteAsync(System.Linq.IQueryable1<!!0>, System.Threading.CancellationToken)'.

Seems like the method is no longer present in version 9.0x of the EF Core libraries:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.relationalqueryableextensions.executedeleteasync?view=efcore-8.0&viewFallbackFrom=efcore-9.0

    <ItemGroup>
        <PackageReference Include="Duende.IdentityServer" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.AspNetIdentity" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.EntityFramework" Version="7.1.0" />
        <PackageReference Include="Duende.IdentityServer.EntityFramework.Storage" Version="7.1.0" />
        <PackageReference Include="Fig" Version="2.0.31" />
        <PackageReference Include="Fig.AppSettingsJson" Version="2.0.31" />
        <PackageReference Include="Microsoft.AspNet.WebApi.Client" Version="6.0.0" />
        <PackageReference Include="Microsoft.AspNetCore.DataProtection.EntityFrameworkCore" Version="6.0.9" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Design" PrivateAssets="All" Version="9.0.1" />
        <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation" Version="6.0.9" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.1" />
        <PackageReference Include="Microsoft.EntityFrameworkCore.Tools" Version="9.0.1">
          <PrivateAssets>all</PrivateAssets>
          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
        </PackageReference>
        <PackageReference Include="Otp.NET" Version="1.4.0" />
        <PackageReference Include="Seq.Extensions.Logging" Version="8.0.0" />

        <PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />

        <PackageReference Include="Serilog.Sinks.Seq" Version="6.0.0" />
    </ItemGroup>

[rofr]

I found the method in a different namespace in 9.0.1:

Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions.ExecuteDeleteAsync()

[maartenba]

(note: we're moving this issue to our new community discussions)

[maartenba]

Just tried exactly that and works like a charm. A repro would be helpful, I suspect there's something off with either target framework or an outdated NuGet restore.

[maartenba]

@rofr If needed here's my repro (use the docker-compose.yml for a SQL Server) - mb/sqlserver branch https://github.com/maartenba/AcmeCorp-IdentityPlayground/tree/mb/sqlserver

[rofr]

Thanks for sharing. We are on net8 if that makes any difference... but anyway I think we can let this go, I think the problem is very clear.

But looking at your repro attempt, I can't see that the operational store is configured, or does that happen automagically based on referenced assemblies? Here is my config.

            .AddOperationalStore(options =>
            {
                options.ConfigureDbContext = builder => builder.UseSqlServer(_ConnectionString);
                options.EnableTokenCleanup = true;
                options.RemoveConsumedTokens = true;
                options.TokenCleanupInterval = 10; // interval in seconds
            });

[maartenba]

Adding it here - https://github.com/maartenba/AcmeCorp-IdentityPlayground/blob/mb/sqlserver/AcmeCorp.IdentityServer/Program.cs#L37

[rofr]

Missed that while browsing, my bad.