Skip to content

Commit 9e50370

Browse files
authoredMar 12, 2025··
chore(Upgrade guide): removed verbiage on button aria-disabled (#4494)
* chore(Upgrade guide): removed verbiage on button aria-disabled * Updated verbiage for ariadisabled being conditionally rendered * Feedback from Erin

File tree

1 file changed

+5
-3
lines changed
  • packages/documentation-site/patternfly-docs/content/get-started

1 file changed

+5
-3
lines changed
 

‎packages/documentation-site/patternfly-docs/content/get-started/upgrade.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,10 @@ If you have previously implemented any breakpoint logic based on a pixel value,
172172
#### Button
173173

174174
1. *Cannot find aria-disabled*
175-
- **Cause:** We changed the `isDisabled` prop to assign a value for `disabled`, but none for `aria-disabled`.
176-
- **Fix:** Remove tests that look for `aria-disabled` in buttons.
175+
- **Cause:** We changed button's `isDisabled` prop to assign a value for `disabled`, but none for `aria-disabled`. The exception to this is when the `component` prop is passed anything other than "button" as a value. Additionally, `aria-disabled` will now only render when true.
176+
- **Fix:** Remove tests that look for `aria-disabled` in buttons when the expectation is either:
177+
- For `aria-disabled` to be false.
178+
- For `aria-disabled` to match `isDisabled` when `component="button"`.
177179

178180
1. *Cannot find button attributes when using byText*
179181
- **Cause:** We added a wrapping `div` around button text. The RTL `byText` query returns that wrapper instead of the button element itself, where button's attributes live.
@@ -199,4 +201,4 @@ Reach out to us on Slack
199201
Ask a question in GitHub Discussions
200202
</Button>
201203

202-
**Note:** If you use a custom solution to replicate PatternFly styling (without using PatternFly components), then your product will need to be re-skinned. This may be a large undertaking, so we encourage you to get help from the PatternFly team.
204+
**Note:** If you use a custom solution to replicate PatternFly styling (without using PatternFly components), then your product will need to be re-skinned. This may be a large undertaking, so we encourage you to get help from the PatternFly team.

0 commit comments

Comments
 (0)
Please sign in to comment.