fix: tests and PR suggestions

pt-tsl · nossila · commit f1b582159de5 · 2025-01-08T16:15:18.000+01:00
diff --git a/baseapp-chats/baseapp_chats/graphql/mutations.py b/baseapp-chats/baseapp_chats/graphql/mutations.py
@@ -137,14 +137,14 @@ def mutate_and_get_payload(cls, root, info, profile_id, participants, is_group,
             image=image,
         )
 
-        ChatRoomParticipant.objects.bulk_create(
+        created_participants = ChatRoomParticipant.objects.bulk_create(
             [
                 ChatRoomParticipant(profile=participant, room=room, accepted_at=timezone.now())
                 for participant in participants
             ]
         )
 
-        room.participants_count = len(participants)
+        room.participants_count = len(created_participants)
         room.save()
 
         return ChatRoomCreate(
diff --git a/baseapp-chats/baseapp_chats/tests/test_graphql_subscriptions.py b/baseapp-chats/baseapp_chats/tests/test_graphql_subscriptions.py
@@ -181,7 +181,7 @@ async def test_user_recieves_message_count_update(django_user_client, graphql_ws
 
     resp = await client.receive(assert_id=sub_id, assert_type="next")
 
-    assert resp["data"]["chatRoomOnMessagesCountUpdate"]["profile"]["unreadMessagesCount"] == 1
-
     # Disconnect and wait the application to finish gracefully.
     await client.finalize()
+
+    assert resp["data"]["chatRoomOnMessagesCountUpdate"]["profile"]["unreadMessagesCount"] == 1

Original file line number	Diff line number	Diff line change
`@@ -137,14 +137,14 @@ def mutate_and_get_payload(cls, root, info, profile_id, participants, is_group,`
`137`	`137`	`image=image,`
`138`	`138`	`)`
`139`	`139`
`140`		`- ChatRoomParticipant.objects.bulk_create(`
	`140`	`+ created_participants = ChatRoomParticipant.objects.bulk_create(`
`141`	`141`	`[`
`142`	`142`	`ChatRoomParticipant(profile=participant, room=room, accepted_at=timezone.now())`
`143`	`143`	`for participant in participants`
`144`	`144`	`]`
`145`	`145`	`)`
`146`	`146`
`147`		`- room.participants_count = len(participants)`
	`147`	`+ room.participants_count = len(created_participants)`
`148`	`148`	`room.save()`
`149`	`149`
`150`	`150`	`return ChatRoomCreate(`