Skip to content
This repository was archived by the owner on May 28, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: pfig/net-amazon-s3
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: saltyduck/net-amazon-s3
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Dec 14, 2014

  1. Fix the latest Moose(2.1403) generates a warning about enum. 

    It says, Passing a list of values to enum is deprecated. Enum values should be wrapped in an arrayref.
    @saltyduck
    saltyduck committed Dec 14, 2014
    Copy the full SHA
    9b80a5b View commit details
Showing with 5 additions and 5 deletions.
  1. +2 −2 lib/Net/Amazon/S3/Client/Object.pm
  2. +1 −1 lib/Net/Amazon/S3/HTTPRequest.pm
  3. +2 −2 lib/Net/Amazon/S3/Request.pm
4 changes: 2 additions & 2 deletions lib/Net/Amazon/S3/Client/Object.pm
View file
Original file line number Diff line number Diff line change
@@ -13,10 +13,10 @@ use IO::File 1.14;
# ABSTRACT: An easy-to-use Amazon S3 client object

enum 'AclShort' =>
qw(private public-read public-read-write authenticated-read);
[qw(private public-read public-read-write authenticated-read)];

enum 'StorageClass' =>
qw(standard reduced_redundancy);
[qw(standard reduced_redundancy)];

has 'client' =>
( is => 'ro', isa => 'Net::Amazon::S3::Client', required => 1 );
2 changes: 1 addition & 1 deletion lib/Net/Amazon/S3/HTTPRequest.pm
View file
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ use URI;
my $METADATA_PREFIX = 'x-amz-meta-';
my $AMAZON_HEADER_PREFIX = 'x-amz-';

enum 'HTTPMethod' => qw(DELETE GET HEAD PUT POST);
enum 'HTTPMethod' => [qw(DELETE GET HEAD PUT POST)];

has 's3' => ( is => 'ro', isa => 'Net::Amazon::S3', required => 1 );
has 'method' => ( is => 'ro', isa => 'HTTPMethod', required => 1 );
4 changes: 2 additions & 2 deletions lib/Net/Amazon/S3/Request.pm
View file
Original file line number Diff line number Diff line change
@@ -7,8 +7,8 @@ use Regexp::Common qw /net/;
# ABSTRACT: Base class for request objects

enum 'AclShort' =>
qw(private public-read public-read-write authenticated-read);
enum 'LocationConstraint' => ( 'US', 'EU' );
[qw(private public-read public-read-write authenticated-read)];
enum 'LocationConstraint' => [ 'US', 'EU' ];

# To comply with Amazon S3 requirements, bucket names must:
# Contain lowercase letters, numbers, periods (.), underscores (_), and dashes (-)