Merge pull request #159 from securesign/health_check-pick

openshift-merge-bot[bot] · web-flow · commit 3c98ae836b24 · 2024-07-29T12:24:22.000Z
Update /healthz probe to use localhost for gRPC readiness checks
diff --git a/cmd/app/http.go b/cmd/app/http.go
@@ -63,7 +63,8 @@ func createHTTPServer(ctx context.Context, serverEndpoint string, grpcServer, le
 	} else {
 		opts = append(opts, grpc.WithTransportCredentials(insecure.NewCredentials()))
 	}
-	cc, err := grpc.NewClient(grpcServer.grpcServerEndpoint, opts...)
+	grpcHealthEndpoint := fmt.Sprintf("localhost:%s", viper.GetString("grpc-port"))
+	cc, err := grpc.NewClient(grpcHealthEndpoint, opts...)
 	if err != nil {
 		log.Logger.Fatal(err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,8 @@ func createHTTPServer(ctx context.Context, serverEndpoint string, grpcServer, le`
`63`	`63`	`} else {`
`64`	`64`	`opts = append(opts, grpc.WithTransportCredentials(insecure.NewCredentials()))`
`65`	`65`	`}`
`66`		`- cc, err := grpc.NewClient(grpcServer.grpcServerEndpoint, opts...)`
	`66`	`+ grpcHealthEndpoint := fmt.Sprintf("localhost:%s", viper.GetString("grpc-port"))`
	`67`	`+ cc, err := grpc.NewClient(grpcHealthEndpoint, opts...)`
`67`	`68`	`if err != nil {`
`68`	`69`	`log.Logger.Fatal(err)`
`69`	`70`	`}`