Merge pull request #930 from securesign/tturek/ensure-tsa

fix: panic error when TSA configuration is nil in Securesign resource

Author: osmman

internal/controller/securesign/actions/ensure_tsa.go

@@ -3,6 +3,7 @@ package actions
 import (
 	"context"
 	"fmt"
+	"reflect"
 
 	rhtasv1alpha1 "github.com/securesign/operator/api/v1alpha1"
 	"github.com/securesign/operator/internal/controller/annotations"
@@ -47,6 +48,19 @@ func (i tsaAction) Handle(ctx context.Context, instance *rhtasv1alpha1.Securesig
 		}
 	)
 
+	if reflect.ValueOf(instance.Spec.TimestampAuthority).IsZero() {
+		if meta.IsStatusConditionTrue(instance.Status.Conditions, TSACondition) {
+			return i.Continue()
+		}
+		meta.SetStatusCondition(&instance.Status.Conditions, v1.Condition{
+			Type:    TSACondition,
+			Status:  v1.ConditionTrue,
+			Reason:  constants.NotDefined,
+			Message: "TSA resource is undefined",
+		})
+		return i.StatusUpdate(ctx, instance)
+	}
+
 	if result, err = kubernetes.CreateOrUpdate(ctx, i.Client,
 		tsa,
 		ensure.ControllerReference[*rhtasv1alpha1.TimestampAuthority](instance, i.Client),

internal/controller/securesign/actions/update_status.go

@@ -60,6 +60,7 @@ func sortByStatus(conditions []v1.Condition) []string {
 			constants.Initialize: 1,
 			constants.Creating:   2,
 			constants.Ready:      3,
+			constants.NotDefined: 4,
 		}
 
 		return order[iCondition.Reason] < order[jCondition.Reason]