Refactor

Author: seratch

functions/languages.ts functions/internals/languages.ts

@@ -1,5 +1,5 @@
 import { DefineFunction, Schema, SlackFunction } from "deno-slack-sdk/mod.ts";
-import { reactionToLang } from "./languages.ts";
+import { reactionToLang } from "./internals/languages.ts";
 import { Logger } from "../utils/logger.ts";
 import { FunctionSourceFile } from "../utils/function_source_file.ts";
 
@@ -10,17 +10,13 @@ export const def = DefineFunction({
   source_file: FunctionSourceFile(import.meta.url),
   input_parameters: {
     properties: {
-      reaction: {
-        type: Schema.types.string,
-      },
+      reaction: { type: Schema.types.string },
     },
     required: ["reaction"],
   },
   output_parameters: {
     properties: {
-      lang: {
-        type: Schema.types.string,
-      },
+      lang: { type: Schema.types.string },
     },
     required: [],
   },

functions/internals.ts functions/internals/trigger_management.ts

@@ -2,7 +2,10 @@ import { DefineFunction, Schema, SlackFunction } from "deno-slack-sdk/mod.ts";
 import { SlackAPI } from "deno-slack-api/mod.ts";
 import { Logger } from "../utils/logger.ts";
 import { FunctionSourceFile } from "../utils/function_source_file.ts";
-import { findTriggerToUpdate, joinAllChannels } from "./internals.ts";
+import {
+  findTriggerToUpdate,
+  joinAllChannels,
+} from "./internals/trigger_management.ts";
 
 export const def = DefineFunction({
   callback_id: "maintain-channel-memberships",

functions/lang_selector.ts

@@ -6,7 +6,7 @@ import {
   createOrUpdateTrigger,
   findTriggerToUpdate,
   joinAllChannels,
-} from "./internals.ts";
+} from "./internals/trigger_management.ts";
 
 export const def = DefineFunction({
   callback_id: "manage-reaction-added-event-trigger",
@@ -15,9 +15,9 @@ export const def = DefineFunction({
   input_parameters: {
     properties: {
       interactivity: { type: Schema.slack.types.interactivity },
-      workflowCallbackId: { type: Schema.types.string },
+      reacjilatorWorkflowCallbackId: { type: Schema.types.string },
     },
-    required: ["interactivity", "workflowCallbackId"],
+    required: ["interactivity", "reacjilatorWorkflowCallbackId"],
   },
   output_parameters: {
     properties: {},
@@ -38,7 +38,7 @@ export default SlackFunction(def, async ({
   const triggerToUpdate = await findTriggerToUpdate(
     client,
     logger,
-    inputs.workflowCallbackId,
+    inputs.reacjilatorWorkflowCallbackId,
   );
   logger.info(`triggerToUpdate: ${JSON.stringify(triggerToUpdate)}`);
 
@@ -62,7 +62,7 @@ export default SlackFunction(def, async ({
     ["configure-workflow"],
     async ({ view, inputs, env, token }) => {
       const logger = Logger(env.LOG_LEVEL);
-      const { workflowCallbackId } = inputs;
+      const { reacjilatorWorkflowCallbackId } = inputs;
       const channelIds = view.state.values.block.channels.selected_channels;
 
       const client = SlackAPI(token);
@@ -71,14 +71,14 @@ export default SlackFunction(def, async ({
         const triggerToUpdate = await findTriggerToUpdate(
           client,
           logger,
-          inputs.workflowCallbackId,
+          inputs.reacjilatorWorkflowCallbackId,
         );
         // If the trigger already exists, we update it.
         // Otherwise, we create a new one.
         await createOrUpdateTrigger(
           client,
           logger,
-          workflowCallbackId,
+          reacjilatorWorkflowCallbackId,
           channelIds,
           triggerToUpdate,
         );

functions/maintenance.ts

@@ -11,23 +11,15 @@ export const def = DefineFunction({
   source_file: FunctionSourceFile(import.meta.url),
   input_parameters: {
     properties: {
-      channelId: {
-        type: Schema.types.string,
-      },
-      messageTs: {
-        type: Schema.types.string,
-      },
-      lang: {
-        type: Schema.types.string,
-      },
+      channelId: { type: Schema.types.string },
+      messageTs: { type: Schema.types.string },
+      lang: { type: Schema.types.string },
     },
     required: ["channelId", "messageTs"],
   },
   output_parameters: {
     properties: {
-      ts: {
-        type: Schema.types.string,
-      },
+      ts: { type: Schema.types.string },
     },
     required: [],
   },

functions/setup.ts

@@ -18,7 +18,7 @@ const workflow = DefineWorkflow({
 
 workflow.addStep(setupDef, {
   interactivity: workflow.inputs.interactivity,
-  workflowCallbackId: reacjilatorDef.definition.callback_id,
+  reacjilatorWorkflowCallbackId: reacjilatorDef.definition.callback_id,
 });
 
 export default workflow;