Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just thoughts on what needs to be sent with each message #7

Open
Just-another-pleb opened this issue Mar 28, 2019 · 2 comments
Open

Comments

@Just-another-pleb
Copy link

I am not getting why the max, min and setpoint need to in every message.

Once set I would have thought that they would remain the same.

Why does it need to have those fixed values sent with every message?

Just asking.

@seth350
Copy link
Owner

seth350 commented May 20, 2019

Sorry, apparently I don't receive emails when someone posts an issue.

I just tested this to see if it was possible to initialize the gauge and then just feed it a payload and it didnt like it.

When I made this, the intention was that the min/max/setpoint would be dynamic. Meaning, it could change at any time.

One of the things I was going to do before I closed the book on this was make it possible to hard code a setpoint/min/max from the node editor. I don't have the time right now to make this change.

@Just-another-pleb
Copy link
Author

Hi Seth.

No problems about the time delay in your reply. I get that things happen.

Sure allow the Max/Min/Setpoints to be dynamic, but why make them mandatory for every message?

My take would be that they can be set with msg.max, msg.min, msg.setpoint parts.
But if the message is (forgive the formatting) msg.payload = 20 (only) then the previous values received as max/min/setpoint are used.

When a new messages arrives with a new value (again: forgive the formatting) msg.payload = 45, msg.max = 60, msg.min = 12

Then the max/min values are updated.

But again: Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants