Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split List view and Grid view demos #121

Closed
sonnyp opened this issue Mar 15, 2024 · 2 comments · Fixed by #124
Closed

Split List view and Grid view demos #121

sonnyp opened this issue Mar 15, 2024 · 2 comments · Fixed by #124
Labels
good first issue Good for newcomers

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Mar 15, 2024

We have Column View which is a separate demo, no reason for List View and Grid View to be together.

Let's split the demo "List View Widgets" into "List View" and "Grid View"
@sonnyp sonnyp added the good first issue Good for newcomers label Mar 15, 2024
@BharatAtbrat
Copy link
Contributor

Screengrabs:

grid.mp4
list.mp4

Do you think these look good?

Also, do we need to change the description for them? I changed the grammar but it's the same sentence for both

@sonnyp
Copy link
Contributor Author

sonnyp commented Mar 16, 2024

Looks like a great start

Please make sure to integrate the recent changes I made in #122

Yes the description needs to be updated - try to come up with something sensible.

Best is to open a PR and discuss there

BharatAtbrat added a commit to BharatAtbrat/action_bar_port_vala that referenced this issue Mar 17, 2024
@BharatAtbrat
demos: Split List View and Grid View
a2d94ad 
Previously, List View widgets had both List View and Grid View
stacked together. Since Column view is a separate demo, It is more
logical to split List View Widgets into List View and Grid View

Initial implementation for separating both views
Descriptions for List View and Grid View may need further refining

Part of workbenchdev#121
@BharatAtbrat BharatAtbrat mentioned this issue Mar 17, 2024
Merged
BharatAtbrat added a commit to BharatAtbrat/action_bar_port_vala that referenced this issue Mar 17, 2024
@BharatAtbrat
demos: Split List View and Grid View
f23702d 
Previously, List View widgets had both List View and Grid View
stacked together. Since Column view is a separate demo, It is more
logical to split List View Widgets into List View and Grid View

Initial implementation for separating both views
Descriptions for List View and Grid View may need further refining

Part of workbenchdev#121
BharatAtbrat added a commit to BharatAtbrat/action_bar_port_vala that referenced this issue Mar 17, 2024
@BharatAtbrat
demos: Split List View and Grid View
5b265b0 
Previously, List View widgets had both List View and Grid View
stacked together. Since Column view is a separate demo, It is more
logical to split List View Widgets into List View and Grid View

Initial implementation for separating both views
Descriptions for List View and Grid View may need further refining

Part of workbenchdev#121
BharatAtbrat added a commit to BharatAtbrat/action_bar_port_vala that referenced this issue Mar 23, 2024
@BharatAtbrat
demos: Split List View and Grid View
f14e79a 
Previously, List View widgets had both List View and Grid View
stacked together. Since Column view is a separate demo, It is more
logical to split List View Widgets into List View and Grid View

Final implementation for separating both views

Change descriptions for List View, Grid View and Column View
to be less verbose as suggested by @sonnyp

Add separate Documentation and Column API reference links
for Column View

Part of workbenchdev#121
@sonnyp sonnyp closed this as completed Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split List View Widgets into "List View" and "Grid View" BharatAtbrat/action_bar_port_vala
2 participants
@sonnyp @BharatAtbrat