Split List View Widgets into "List View" and "Grid View" #124
+186
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BharatAtbrat
force-pushed
the
add_list_grid_view
branch
2 times, most recently
from
bc810e3 to
5b265b0
Compare
sonnyp
requested changes
Mar 23, 2024
src/Grid View/main.blp
Outdated
|
|
||
| Adw.StatusPage { | ||
| title: _("Grid View"); | ||
| description: _("Grid view presents a dynamic list of model items arranged in a grid"); |
There was a problem hiding this comment.
Suggested change
| description: _("Grid view presents a dynamic list of model items arranged in a grid"); | |
| description: _("Arrange a large and dynamic list of items in a grid"); |
(don't forget to update main.json)
src/List View/main.blp
Outdated
| title: _("List View Widgets"); | ||
| description: _("List and Grid views present a large dynamic list of model items"); | ||
| title: _("List View"); | ||
| description: _("List View presents a dynamic list of vertically stacked model items"); |
There was a problem hiding this comment.
Suggested change
| description: _("List View presents a dynamic list of vertically stacked model items"); | |
| description: _("Arrange a large and dynamic list of items one after the other"); |
(don't forget to update main.json)
On it! Marking this ready, let me know if this isn't the correct change for the links <:) |
Previously, List View widgets had both List View and Grid View stacked together. Since Column view is a separate demo, It is more logical to split List View Widgets into List View and Grid View Final implementation for separating both views Change descriptions for List View, Grid View and Column View to be less verbose as suggested by @sonnyp Add separate Documentation and Column API reference links for Column View Part of workbenchdev#121
BharatAtbrat
force-pushed
the
add_list_grid_view
branch
from
8712dbd to
f14e79a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121
List View Widgets had List View and Grid View stacked together, they can split into two
separate demos.
Introduced initial implementation for the same, Descriptions for both may need further discussion
Let me know any changes that need to be done
Screengrabs for the changes :
Grid View
2024-03-17.21-05-16.mp4
List View
2024-03-17.21-04-46.mp4
Part of #121