Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default minperl From 5.006 to 5.008. #54

Open
jgamble opened this issue Jul 20, 2015 · 2 comments
Open

Change Default minperl From 5.006 to 5.008. #54

jgamble opened this issue Jul 20, 2015 · 2 comments

Comments

@jgamble
Copy link

jgamble commented Jul 20, 2015

Change default minperl to '5.008'.

(No diff provided, it's just one change on line 109 in Simple.pm.)

I'm not going to use the age argument, since the difference between 5.6 and 5.8's
end-of-life is a mere five years (see http://www.cpan.org/src/README.html.

But setting a higher minimum does prevent some basic problems. I have been seeing
more newly-created modules with a 5.6 minimum enter CPAN recently, and at the very
least I feel that setting a higher minimum will help reduce Unicode problems and
ensure that tainted data is caught (see http://perldoc.perl.org/perl58delta.html).

(For what it's worth, I was going to argue for a minimum of 5.10, where recursive
regex's were introduced, but... baby steps.)

@Grinnz
Copy link
Collaborator

Grinnz commented Mar 28, 2017

I feel it should still be the author's choice whether they want to change the minimum perl version for their module. The downside of setting your minperl to 5.8 by default is that you no longer get cpantesters results to check if 5.6 actually works. At this point it is mostly assumed that lots of things do not work on 5.6 regardless of listed minimum, so if someone wants to install things on 5.6 they accept the responsibility of fixing modules, and are probably aware that a minimum perl of 5.6 does not guarantee it will work there.

@jgamble
Copy link
Author

jgamble commented Mar 28, 2017

It is the author's choice to change the minimum Perl version -- always has been (see the options on module-starter). The proposed change is for the people who have opted out of choosing. There are significant problems in earlier Perls with respect to unicode and security (as noted above), and unless you have a strong reason for using them, you should be using a later version.

There is no downside to not seeing if an earlier version of Perl works if you haven't bothered to set a minimum in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants