Skip to content

Commit 1bc9fb4

Browse files
akpm00sfrothwell
authored andcommitted
mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites-checkpatch-fixes
WARNING: Missing a blank line after declarations torvalds#34: FILE: include/linux/page_idle.h:50: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); WARNING: Missing a blank line after declarations torvalds#45: FILE: include/linux/page_idle.h:60: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); WARNING: Missing a blank line after declarations torvalds#57: FILE: include/linux/page_idle.h:70: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); WARNING: Missing a blank line after declarations torvalds#68: FILE: include/linux/page_idle.h:80: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); WARNING: Missing a blank line after declarations torvalds#79: FILE: include/linux/page_idle.h:90: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); WARNING: Missing a blank line after declarations torvalds#90: FILE: include/linux/page_idle.h:100: + struct page_ext *page_ext; + page_ext = lookup_page_ext(page); total: 1 errors, 6 warnings, 196 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/mm-check-the-return-value-of-lookup_page_ext-for-all-call-sites.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Yang Shi <yang.shi@linaro.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent cd42b99 commit 1bc9fb4

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

include/linux/page_idle.h

+12-12
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ extern struct page_ext_operations page_idle_ops;
4646

4747
static inline bool page_is_young(struct page *page)
4848
{
49-
struct page_ext *page_ext;
50-
page_ext = lookup_page_ext(page);
49+
struct page_ext *page_ext = lookup_page_ext(page);
50+
5151
if (unlikely(!page_ext))
5252
return false;
5353

@@ -56,8 +56,8 @@ static inline bool page_is_young(struct page *page)
5656

5757
static inline void set_page_young(struct page *page)
5858
{
59-
struct page_ext *page_ext;
60-
page_ext = lookup_page_ext(page);
59+
struct page_ext *page_ext = lookup_page_ext(page);
60+
6161
if (unlikely(!page_ext))
6262
return;
6363

@@ -66,8 +66,8 @@ static inline void set_page_young(struct page *page)
6666

6767
static inline bool test_and_clear_page_young(struct page *page)
6868
{
69-
struct page_ext *page_ext;
70-
page_ext = lookup_page_ext(page);
69+
struct page_ext *page_ext = lookup_page_ext(page);
70+
7171
if (unlikely(!page_ext))
7272
return false;
7373

@@ -76,8 +76,8 @@ static inline bool test_and_clear_page_young(struct page *page)
7676

7777
static inline bool page_is_idle(struct page *page)
7878
{
79-
struct page_ext *page_ext;
80-
page_ext = lookup_page_ext(page);
79+
struct page_ext *page_ext = lookup_page_ext(page);
80+
8181
if (unlikely(!page_ext))
8282
return false;
8383

@@ -86,8 +86,8 @@ static inline bool page_is_idle(struct page *page)
8686

8787
static inline void set_page_idle(struct page *page)
8888
{
89-
struct page_ext *page_ext;
90-
page_ext = lookup_page_ext(page);
89+
struct page_ext *page_ext = lookup_page_ext(page);
90+
9191
if (unlikely(!page_ext))
9292
return;
9393

@@ -96,8 +96,8 @@ static inline void set_page_idle(struct page *page)
9696

9797
static inline void clear_page_idle(struct page *page)
9898
{
99-
struct page_ext *page_ext;
100-
page_ext = lookup_page_ext(page);
99+
struct page_ext *page_ext = lookup_page_ext(page);
100+
101101
if (unlikely(!page_ext))
102102
return;
103103

0 commit comments

Comments
 (0)