Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Eq and (De)Serializable for AdviceMap #1448

Closed
igamigo opened this issue Aug 12, 2024 · 0 comments · Fixed by #1494
Closed

Implement Eq and (De)Serializable for AdviceMap #1448

igamigo opened this issue Aug 12, 2024 · 0 comments · Fixed by #1494
Labels
good first issue Good for newcomers processor Related to Miden VM processor

Comments

@igamigo
Copy link

igamigo commented Aug 12, 2024

In order to enable serialization and comparison of objects related to transactions, AdviceMap should implement Serializable, Deserializable, and Eq.

More context here: 0xPolygonMiden/miden-client#471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers processor Related to Miden VM processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add PartialEq,Eq and De/Serialize for AdviceInputs and AdviceMap lambdaclass/miden-vm
2 participants
@plafer @igamigo