Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syscall and call should be allowed in kernel modules #1681

Open
plafer opened this issue Mar 4, 2025 · 1 comment
Open

Syscall and call should be allowed in kernel modules #1681

plafer opened this issue Mar 4, 2025 · 1 comment
Labels
assembly Related to Miden assembly

Comments

@plafer
Copy link
Contributor

plafer commented Mar 4, 2025

While looking into #1680, I noticed that the assembler rejects syscalls and calls in kernel modules. If I am not mistaken, this is too strict: we should allow calls/syscalls in the root context if we're not processing a syscall (i.e. in_syscall flag is false). It is also inconsitent that dyncall is currently allowed, but not call and syscall.

Hence, I think we should remove that check from the assembler.

@plafer plafer added the assembly Related to Miden assembly label Mar 4, 2025
@bobbinth
Copy link
Contributor

bobbinth commented Mar 5, 2025

I think allowing call should be pretty straight-forward (since dyncall is allowed already), but syscall may require more thinking. The main concern is about how we handle fmp register when performing a syscall. It actually may be fine as is, but we need to make sure it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assembly Related to Miden assembly
Projects
None yet
Development

No branches or pull requests

2 participants