Skip to content

Commit 3a2d37e

Browse files
committed
Make the logger configurable with a new WithLogger method on the builders
This will enable a seamless integration with xUnit.net (both ITestOutputHelper and IMessageSink) Fixes testcontainers#996
1 parent 8aee376 commit 3a2d37e

File tree

139 files changed

+261
-342
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

139 files changed

+261
-342
lines changed

src/Templates/CSharp/Testcontainers.ModuleName/ModuleNameContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class ModuleNameContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="ModuleNameContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public ModuleNameContainer(ModuleNameConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public ModuleNameContainer(ModuleNameConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615
}

src/Testcontainers.ActiveMq/ArtemisBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public ArtemisBuilder WithPassword(string password)
6262
public override ArtemisContainer Build()
6363
{
6464
Validate();
65-
return new ArtemisContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
65+
return new ArtemisContainer(DockerResourceConfiguration);
6666
}
6767

6868
/// <inheritdoc />

src/Testcontainers.ActiveMq/ArtemisContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class ArtemisContainer : DockerContainer
1010
/// Initializes a new instance of the <see cref="ArtemisContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public ArtemisContainer(ActiveMqConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public ArtemisContainer(ActiveMqConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
}

src/Testcontainers.ActiveMq/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
global using DotNet.Testcontainers.Builders;
55
global using DotNet.Testcontainers.Configurations;
66
global using DotNet.Testcontainers.Containers;
7-
global using JetBrains.Annotations;
8-
global using Microsoft.Extensions.Logging;
7+
global using JetBrains.Annotations;

src/Testcontainers.ArangoDb/ArangoDbBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public ArangoDbBuilder WithPassword(string password)
4949
public override ArangoDbContainer Build()
5050
{
5151
Validate();
52-
return new ArangoDbContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
52+
return new ArangoDbContainer(DockerResourceConfiguration);
5353
}
5454

5555
/// <inheritdoc />

src/Testcontainers.ArangoDb/ArangoDbContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class ArangoDbContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="ArangoDbContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public ArangoDbContainer(ArangoDbConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public ArangoDbContainer(ArangoDbConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.ArangoDb/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
global using DotNet.Testcontainers.Builders;
55
global using DotNet.Testcontainers.Configurations;
66
global using DotNet.Testcontainers.Containers;
7-
global using JetBrains.Annotations;
8-
global using Microsoft.Extensions.Logging;
7+
global using JetBrains.Annotations;

src/Testcontainers.Azurite/AzuriteBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public override AzuriteContainer Build()
8686
}
8787

8888
var azuriteBuilder = DockerResourceConfiguration.WaitStrategies.Count() > 1 ? this : WithWaitStrategy(waitStrategy);
89-
return new AzuriteContainer(azuriteBuilder.DockerResourceConfiguration, TestcontainersSettings.Logger);
89+
return new AzuriteContainer(azuriteBuilder.DockerResourceConfiguration);
9090
}
9191

9292
/// <inheritdoc />

src/Testcontainers.Azurite/AzuriteContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ public sealed class AzuriteContainer : DockerContainer
1212
/// Initializes a new instance of the <see cref="AzuriteContainer" /> class.
1313
/// </summary>
1414
/// <param name="configuration">The container configuration.</param>
15-
/// <param name="logger">The logger.</param>
16-
public AzuriteContainer(AzuriteConfiguration configuration, ILogger logger)
17-
: base(configuration, logger)
15+
public AzuriteContainer(AzuriteConfiguration configuration)
16+
: base(configuration)
1817
{
1918
}
2019

src/Testcontainers.Azurite/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@
55
global using DotNet.Testcontainers.Builders;
66
global using DotNet.Testcontainers.Configurations;
77
global using DotNet.Testcontainers.Containers;
8-
global using JetBrains.Annotations;
9-
global using Microsoft.Extensions.Logging;
8+
global using JetBrains.Annotations;

src/Testcontainers.BigQuery/BigQueryBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public BigQueryBuilder WithProject(string projectId)
4646
public override BigQueryContainer Build()
4747
{
4848
Validate();
49-
return new BigQueryContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
49+
return new BigQueryContainer(DockerResourceConfiguration);
5050
}
5151

5252
/// <inheritdoc />

src/Testcontainers.BigQuery/BigQueryContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class BigQueryContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="BigQueryContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public BigQueryContainer(BigQueryConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public BigQueryContainer(BigQueryConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.BigQuery/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
global using DotNet.Testcontainers.Builders;
44
global using DotNet.Testcontainers.Configurations;
55
global using DotNet.Testcontainers.Containers;
6-
global using JetBrains.Annotations;
7-
global using Microsoft.Extensions.Logging;
6+
global using JetBrains.Annotations;

src/Testcontainers.Bigtable/BigtableBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ private BigtableBuilder(BigtableConfiguration resourceConfiguration)
3434
public override BigtableContainer Build()
3535
{
3636
Validate();
37-
return new BigtableContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
37+
return new BigtableContainer(DockerResourceConfiguration);
3838
}
3939

4040
/// <inheritdoc />

src/Testcontainers.Bigtable/BigtableContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class BigtableContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="BigtableContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public BigtableContainer(IContainerConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public BigtableContainer(IContainerConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.Bigtable/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
global using DotNet.Testcontainers.Builders;
44
global using DotNet.Testcontainers.Configurations;
55
global using DotNet.Testcontainers.Containers;
6-
global using JetBrains.Annotations;
7-
global using Microsoft.Extensions.Logging;
6+
global using JetBrains.Annotations;

src/Testcontainers.ClickHouse/ClickHouseBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public ClickHouseBuilder WithPassword(string password)
7575
public override ClickHouseContainer Build()
7676
{
7777
Validate();
78-
return new ClickHouseContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
78+
return new ClickHouseContainer(DockerResourceConfiguration);
7979
}
8080

8181
/// <inheritdoc />

src/Testcontainers.ClickHouse/ClickHouseContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class ClickHouseContainer : DockerContainer, IDatabaseContainer
1010
/// Initializes a new instance of the <see cref="ClickHouseContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public ClickHouseContainer(ClickHouseConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public ClickHouseContainer(ClickHouseConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
}

src/Testcontainers.ClickHouse/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,4 @@
1111
global using DotNet.Testcontainers.Builders;
1212
global using DotNet.Testcontainers.Configurations;
1313
global using DotNet.Testcontainers.Containers;
14-
global using JetBrains.Annotations;
15-
global using Microsoft.Extensions.Logging;
14+
global using JetBrains.Annotations;

src/Testcontainers.CockroachDb/CockroachDbBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public CockroachDbBuilder WithPassword(string password)
7575
public override CockroachDbContainer Build()
7676
{
7777
Validate();
78-
return new CockroachDbContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
78+
return new CockroachDbContainer(DockerResourceConfiguration);
7979
}
8080

8181
/// <inheritdoc />

src/Testcontainers.CockroachDb/CockroachDbContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class CockroachDbContainer : DockerContainer, IDatabaseContainer
1010
/// Initializes a new instance of the <see cref="CockroachDbContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public CockroachDbContainer(CockroachDbConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public CockroachDbContainer(CockroachDbConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
}

src/Testcontainers.CockroachDb/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@
1010
global using DotNet.Testcontainers.Builders;
1111
global using DotNet.Testcontainers.Configurations;
1212
global using DotNet.Testcontainers.Containers;
13-
global using JetBrains.Annotations;
14-
global using Microsoft.Extensions.Logging;
13+
global using JetBrains.Annotations;

src/Testcontainers.Consul/ConsulBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ private ConsulBuilder(ConsulConfiguration resourceConfiguration)
3636
public override ConsulContainer Build()
3737
{
3838
Validate();
39-
return new ConsulContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
39+
return new ConsulContainer(DockerResourceConfiguration);
4040
}
4141

4242
/// <inheritdoc />

src/Testcontainers.Consul/ConsulContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class ConsulContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="ConsulContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public ConsulContainer(ConsulConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public ConsulContainer(ConsulConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.Consul/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
global using DotNet.Testcontainers.Builders;
44
global using DotNet.Testcontainers.Configurations;
55
global using DotNet.Testcontainers.Containers;
6-
global using JetBrains.Annotations;
7-
global using Microsoft.Extensions.Logging;
6+
global using JetBrains.Annotations;

src/Testcontainers.CosmosDb/CosmosDbBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ private CosmosDbBuilder(CosmosDbConfiguration resourceConfiguration)
3636
public override CosmosDbContainer Build()
3737
{
3838
Validate();
39-
return new CosmosDbContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
39+
return new CosmosDbContainer(DockerResourceConfiguration);
4040
}
4141

4242
/// <inheritdoc />

src/Testcontainers.CosmosDb/CosmosDbContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class CosmosDbContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="CosmosDbContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public CosmosDbContainer(CosmosDbConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public CosmosDbContainer(CosmosDbConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.CosmosDb/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@
88
global using DotNet.Testcontainers.Builders;
99
global using DotNet.Testcontainers.Configurations;
1010
global using DotNet.Testcontainers.Containers;
11-
global using JetBrains.Annotations;
12-
global using Microsoft.Extensions.Logging;
11+
global using JetBrains.Annotations;

src/Testcontainers.CouchDb/CouchDbBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public CouchDbBuilder WithPassword(string password)
6060
public override CouchDbContainer Build()
6161
{
6262
Validate();
63-
return new CouchDbContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
63+
return new CouchDbContainer(DockerResourceConfiguration);
6464
}
6565

6666
/// <inheritdoc />

src/Testcontainers.CouchDb/CouchDbContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class CouchDbContainer : DockerContainer
1010
/// Initializes a new instance of the <see cref="CouchDbContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public CouchDbContainer(CouchDbConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public CouchDbContainer(CouchDbConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
}

src/Testcontainers.CouchDb/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
global using DotNet.Testcontainers.Builders;
55
global using DotNet.Testcontainers.Configurations;
66
global using DotNet.Testcontainers.Containers;
7-
global using JetBrains.Annotations;
8-
global using Microsoft.Extensions.Logging;
7+
global using JetBrains.Annotations;

src/Testcontainers.Couchbase/CouchbaseBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ public override CouchbaseContainer Build()
122122
}
123123

124124
var couchbaseBuilder = DockerResourceConfiguration.WaitStrategies.Count() > 1 ? this : WithWaitStrategy(waitStrategy);
125-
return new CouchbaseContainer(couchbaseBuilder.DockerResourceConfiguration, TestcontainersSettings.Logger);
125+
return new CouchbaseContainer(couchbaseBuilder.DockerResourceConfiguration);
126126
}
127127

128128
/// <inheritdoc />

src/Testcontainers.Couchbase/CouchbaseContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class CouchbaseContainer : DockerContainer
1010
/// Initializes a new instance of the <see cref="CouchbaseContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public CouchbaseContainer(CouchbaseConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public CouchbaseContainer(CouchbaseConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
Starting += (_, _) => Logger.LogInformation("Couchbase container is starting, performing configuration.");

src/Testcontainers.DynamoDb/DynamoDbBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ private DynamoDbBuilder(DynamoDbConfiguration dockerResourceConfiguration)
3434
public override DynamoDbContainer Build()
3535
{
3636
Validate();
37-
return new DynamoDbContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
37+
return new DynamoDbContainer(DockerResourceConfiguration);
3838
}
3939

4040
/// <inheritdoc />

src/Testcontainers.DynamoDb/DynamoDbContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ public sealed class DynamoDbContainer : DockerContainer
88
/// Initializes a new instance of the <see cref="DynamoDbContainer" /> class.
99
/// </summary>
1010
/// <param name="configuration">The container configuration.</param>
11-
/// <param name="logger">The logger.</param>
12-
public DynamoDbContainer(DynamoDbConfiguration configuration, ILogger logger)
13-
: base(configuration, logger)
11+
public DynamoDbContainer(DynamoDbConfiguration configuration)
12+
: base(configuration)
1413
{
1514
}
1615

src/Testcontainers.DynamoDb/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,4 @@
44
global using DotNet.Testcontainers.Builders;
55
global using DotNet.Testcontainers.Configurations;
66
global using DotNet.Testcontainers.Containers;
7-
global using JetBrains.Annotations;
8-
global using Microsoft.Extensions.Logging;
7+
global using JetBrains.Annotations;

src/Testcontainers.Elasticsearch/ElasticsearchBuilder.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public ElasticsearchBuilder WithPassword(string password)
5959
public override ElasticsearchContainer Build()
6060
{
6161
Validate();
62-
return new ElasticsearchContainer(DockerResourceConfiguration, TestcontainersSettings.Logger);
62+
return new ElasticsearchContainer(DockerResourceConfiguration);
6363
}
6464

6565
/// <inheritdoc />

src/Testcontainers.Elasticsearch/ElasticsearchContainer.cs

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ public sealed class ElasticsearchContainer : DockerContainer
1010
/// Initializes a new instance of the <see cref="ElasticsearchContainer" /> class.
1111
/// </summary>
1212
/// <param name="configuration">The container configuration.</param>
13-
/// <param name="logger">The logger.</param>
14-
public ElasticsearchContainer(ElasticsearchConfiguration configuration, ILogger logger)
15-
: base(configuration, logger)
13+
public ElasticsearchContainer(ElasticsearchConfiguration configuration)
14+
: base(configuration)
1615
{
1716
_configuration = configuration;
1817
}

src/Testcontainers.Elasticsearch/Usings.cs

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,4 @@
88
global using DotNet.Testcontainers.Builders;
99
global using DotNet.Testcontainers.Configurations;
1010
global using DotNet.Testcontainers.Containers;
11-
global using JetBrains.Annotations;
12-
global using Microsoft.Extensions.Logging;
11+
global using JetBrains.Annotations;

0 commit comments

Comments
 (0)