fix(arborist): fix superfluous arguments (npm#4464)

Author: XhmikosR

workspaces/arborist/test/audit-report.js

@@ -30,7 +30,7 @@ const sortReport = report => {
       {
         ...vuln,
         via: (vuln.via || []).sort((a, b) =>
-          String(a.source || a).localeCompare(String(b.source || b, 'en'))),
+          String(a.source || a).localeCompare(String(b.source || b), 'en')),
         effects: (vuln.effects || []).sort((a, b) => a.localeCompare(b, 'en')),
       },
     ])

workspaces/arborist/test/diff.js

@@ -31,7 +31,7 @@ const formatDiff = obj =>
     removed: obj.removed.map(d => normalizePath(d.path).split(normalizedCWD).join('{CWD}')),
     children: [...obj.children]
       .map(formatDiff)
-      .sort((a, b) => path(a).localeCompare(path(b, 'en'))),
+      .sort((a, b) => path(a).localeCompare(path(b), 'en')),
   })
 
 t.formatSnapshot = obj => format(formatDiff(obj), { sort: false })

workspaces/arborist/test/inventory.js

@@ -21,7 +21,7 @@ t.test('basic operations', t => {
     i.get('y'),
   ], 'filter returns an iterable of all matching nodes')
 
-  t.same([...i.query('license')].sort((a, b) => String(a).localeCompare(String(b, 'en'))),
+  t.same([...i.query('license')].sort((a, b) => String(a).localeCompare(String(b), 'en')),
     ['ISC', 'MIT', undefined])
   t.same([...i.query('license', 'MIT')], [
     { location: 'x', name: 'x', package: { licence: 'MIT', funding: 'foo' } },
@@ -33,7 +33,7 @@ t.test('basic operations', t => {
     { location: 'x', name: 'x', package: { licence: 'MIT', funding: 'foo' } },
     { location: 'y', name: 'x', package: { licenses: [{ type: 'ISC' }], funding: { url: 'foo' } } },
   ], 'can query by name')
-  t.same([...i.query('funding')].sort((a, b) => String(a).localeCompare(String(b, 'en'))),
+  t.same([...i.query('funding')].sort((a, b) => String(a).localeCompare(String(b), 'en')),
     ['bar', 'foo', undefined])
   t.same([...i.query('funding', 'foo')], [
     { location: 'x', name: 'x', package: { licence: 'MIT', funding: 'foo' } },