Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of plugin-resources #1830

Closed
evd0kim opened this issue May 29, 2021 · 2 comments · Fixed by #1837
Closed

Location of plugin-resources #1830

evd0kim opened this issue May 29, 2021 · 2 comments · Fixed by #1837

Comments

@evd0kim
Copy link
Contributor

evd0kim commented May 29, 2021

Currently Eclair looks for plugin-resources directory from inside the directory run-eclair was invoked.

Is it possible for node to look for plugin configs relatively to .eclair dir or eclair.conf?

@akumaigorodski
Copy link
Contributor

A bit to clarify here: plugin-resources is a directory I've started using when I realized that my HC plugin needs a config file of its own and also other file stuff (such as icon image). So I've decided to introduce a ./plugin-resources/<plugin-name>/ approach which is used in HC plugin and now in alarm bot plugin.

I guess if this makes sense then at some point these approaches need to be solidified on some "plugin best practices" section or something like that.

@evd0kim
Copy link
Contributor Author

evd0kim commented May 31, 2021

Thank you very much @btcontract. I didn't realize this is only hosted-channels thing and did the same in Telegram warnings bot just because it is convenient to have separate config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants