Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions regarding using the asset uploader #407

Open
jtdemer opened this issue Jan 10, 2025 · 1 comment
Open

Questions regarding using the asset uploader #407

jtdemer opened this issue Jan 10, 2025 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@jtdemer
Copy link

jtdemer commented Jan 10, 2025

Im asking my self how flexible is the current pre validation of the asset uploader also in regards to other domains.

Two things allready jumped into my mind by looking at the code and try it out.

Is it necessary to check the readme file in the asset?

Reading the asset definition in the readme file potential dataprovider are flexible by adding optional files. Why are we checking a fixed number here?

const checkIfAllFilesInManifestExistStub = jest.fn().mockResolvedValue({
errors: [],
amount: 12,
})

@jtdemer jtdemer added the question Further information is requested label Jan 10, 2025
@jdsika jdsika assigned jeroenbranje and unassigned afwalser Jan 13, 2025
@jdsika
Copy link
Contributor

jdsika commented Jan 13, 2025

@jeroenbranje magic number in code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants