Elimination of unused define + writing the configured number of decimals

Author: AbelPau

ogr/ogrsf_frmts/miramon/mm_gdal_driver_structs.h

@@ -318,12 +318,10 @@ struct MiraMonVectorMetaData
 struct MiraMonFieldValue
 {
     MM_BOOLEAN bIsValid;  // If 1 the value is filled. If 0, there is no value.
-#define MM_INIT_STRING_FIELD_VALUE 50000  // Never less than 10
-    MM_EXT_DBF_N_FIELDS nNumDinValue;     // Size of the reserved string value
-    char *pDinValue;  // Used if MM_MAX_STRING_FIELD_VALUE is not enough
-    double dValue;    // For double and 32 bit integer numeric values
-    GInt64 iValue;    // For 64 bit integer values.
-    //MM_BOOLEAN kbValue;    // For binary values.
+    MM_EXT_DBF_N_FIELDS nNumDinValue;  // Size of the reserved string value
+    char *pDinValue;                   // Used to store the value as string
+    double dValue;  // For double and 32 bit integer numeric values
+    GInt64 iValue;  // For 64 bit integer values.
 };
 
 struct MiraMonRecord

ogr/ogrsf_frmts/miramon/ogrmiramonlayer.cpp

@@ -2067,6 +2067,10 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
         return OGRERR_NONE;
     }
 
+    if (!phMiraMonLayer || !phMiraMonLayer->pLayerDB ||
+        !phMiraMonLayer->pLayerDB->pFields)
+        return OGRERR_INVALID_HANDLE;
+
     MM_EXT_DBF_N_MULTIPLE_RECORDS nIRecord;
     int nNumFields = m_poFeatureDefn->GetFieldCount();
     MM_EXT_DBF_N_MULTIPLE_RECORDS nNumRecords, nRealNumRecords;
@@ -2262,7 +2266,9 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
 
                 if (MM_SecureCopyStringFieldValue(
                         &hMMFeature.pRecords[nIRecord].pField[iField].pDinValue,
-                        CPLSPrintf("%.*f", MAX_RELIABLE_SF_DOUBLE,
+                        CPLSPrintf("%.*f",
+                                   phMiraMonLayer->pLayerDB->pFields[iField]
+                                       .nNumberOfDecimals,
                                    padfRLValues[nIRecord]),
                         &hMMFeature.pRecords[nIRecord]
                              .pField[iField]
@@ -2412,7 +2418,9 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
 
             if (MM_SecureCopyStringFieldValue(
                     &hMMFeature.pRecords[0].pField[iField].pDinValue,
-                    CPLSPrintf("%.*f", MAX_RELIABLE_SF_DOUBLE,
+                    CPLSPrintf("%.*f",
+                               phMiraMonLayer->pLayerDB->pFields[iField]
+                                   .nNumberOfDecimals,
                                poFeature->GetFieldAsDouble(iField)),
                     &hMMFeature.pRecords[0].pField[iField].nNumDinValue))
                 return OGRERR_NOT_ENOUGH_MEMORY;