Skip to content

Commit ac6a58f

Browse files
committed
Elimination of an unuseful variable dValue. All is formated in pDinValue
1 parent 1bd6985 commit ac6a58f

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

ogr/ogrsf_frmts/miramon/mm_gdal_driver_structs.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,7 @@ struct MiraMonFieldValue
323323
MM_BOOLEAN bIsValid; // If 1 the value is filled. If 0, there is no value.
324324
MM_EXT_DBF_N_FIELDS nNumDinValue; // Size of the reserved string value
325325
char *pDinValue; // Used to store the value as string
326-
double dValue; // For double and 32 bit integer numeric values
327-
GInt64 iValue; // For 64 bit integer values.
326+
GInt64 iValue; // For 64 bit integer values.
328327
};
329328

330329
struct MiraMonRecord

ogr/ogrsf_frmts/miramon/mm_wrlayr.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -6735,7 +6735,7 @@ static int MMAddFeatureRecordToMMDB(struct MiraMonVectLayerInfo *hMiraMonLayer,
67356735
pBD_XP->pField + nIField + nNumPrivateMMField,
67366736
&hMMFeature->pRecords[nIRecord]
67376737
.pField[nIField]
6738-
.dValue,
6738+
.pDinValue,
67396739
FALSE))
67406740
return 1;
67416741
}

ogr/ogrsf_frmts/miramon/ogrmiramonlayer.cpp

+1-12
Original file line numberDiff line numberDiff line change
@@ -2183,9 +2183,6 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
21832183
hMMFeature.pRecords[nIRecord].nNumField))
21842184
return OGRERR_NOT_ENOUGH_MEMORY;
21852185

2186-
hMMFeature.pRecords[nIRecord].pField[iField].dValue =
2187-
panValues[nIRecord];
2188-
21892186
if (MM_SecureCopyStringFieldValue(
21902187
&hMMFeature.pRecords[nIRecord].pField[iField].pDinValue,
21912188
CPLSPrintf("%d", panValues[nIRecord]),
@@ -2272,14 +2269,11 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
22722269
hMMFeature.pRecords[nIRecord].nNumField))
22732270
return OGRERR_NOT_ENOUGH_MEMORY;
22742271

2275-
hMMFeature.pRecords[nIRecord].pField[iField].dValue =
2276-
padfRLValues[nIRecord];
2277-
22782272
char szChain[21];
22792273
SprintfDoubleSignifFigures(
22802274
szChain, 21,
22812275
phMiraMonLayer->pLayerDB->pFields[iField].nNumberOfDecimals,
2282-
hMMFeature.pRecords[nIRecord].pField[iField].dValue);
2276+
padfRLValues[nIRecord]);
22832277

22842278
if (MM_SecureCopyStringFieldValue(
22852279
&hMMFeature.pRecords[nIRecord].pField[iField].pDinValue,
@@ -2391,8 +2385,6 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
23912385
hMMFeature.pRecords[0].nNumField))
23922386
return OGRERR_NOT_ENOUGH_MEMORY;
23932387

2394-
hMMFeature.pRecords[0].pField[iField].dValue =
2395-
poFeature->GetFieldAsInteger(iField);
23962388
if (MM_SecureCopyStringFieldValue(
23972389
&hMMFeature.pRecords[0].pField[iField].pDinValue,
23982390
pszRawValue,
@@ -2431,9 +2423,6 @@ OGRErr OGRMiraMonLayer::TranslateFieldsValuesToMM(OGRFeature *poFeature)
24312423
hMMFeature.pRecords[0].nNumField))
24322424
return OGRERR_NOT_ENOUGH_MEMORY;
24332425

2434-
hMMFeature.pRecords[0].pField[iField].dValue =
2435-
poFeature->GetFieldAsDouble(iField);
2436-
24372426
char szChain[21];
24382427
SprintfDoubleSignifFigures(
24392428
szChain, 21,

0 commit comments

Comments
 (0)