fix(agoric-cli): use SDK binaries rather than relying on $PATH

Author: michaelfig

packages/agoric-cli/lib/cosmos.js

@@ -1,5 +1,5 @@
 import chalk from 'chalk';
-import { makePspawn } from './helpers.js';
+import { makePspawn, getSDKBinaries } from './helpers.js';
 
 export default async function cosmosMain(progname, rawArgs, powers, opts) {
   const IMAGE = `agoric/agoric-sdk`;
@@ -21,7 +21,8 @@ export default async function cosmosMain(progname, rawArgs, powers, opts) {
 
   function helper(args, hopts = undefined) {
     if (opts.sdk) {
-      return pspawn('ag-cosmos-helper', args, hopts);
+      const { cosmosHelper } = getSDKBinaries();
+      return pspawn(cosmosHelper, args, hopts);
     }
 
     // Don't allocate a TTY if we're not talking to one.

packages/agoric-cli/lib/helpers.js

@@ -3,11 +3,24 @@
 
 /** @typedef {import('child_process').ChildProcess} ChildProcess */
 
+export const getSDKBinaries = () => {
+  const myUrl = import.meta.url;
+  return {
+    agSolo: new URL('../../solo/src/entrypoint.js', myUrl).pathname,
+    cosmosChain: new URL('../../cosmic-swingset/bin/ag-chain-cosmos', myUrl)
+      .pathname,
+    cosmosHelper: new URL(
+      '../../../golang/cosmos/build/ag-cosmos-helper',
+      myUrl,
+    ).pathname,
+  };
+};
+
 /**
  * Create a promisified spawn function with the following built-in parameters.
  *
  * @param {Object} param0
- * @param {Record<string, string>} [param0.env] the default environment
+ * @param {Record<string, string | undefined>} [param0.env] the default environment
  * @param {*} [param0.chalk] a colorizer
  * @param {Console} [param0.log] a console object
  * @param {(cmd: string, cargs: Array<string>, opts: any) => ChildProcess}param0.spawn the spawn function
@@ -26,7 +39,7 @@ export const makePspawn = ({
    * @param {Object} param2
    * @param {string | [string, string, string]} [param2.stdio] standard IO
    * specification
-   * @param {Record<string, string>} [param2.env] environment
+   * @param {Record<string, string | undefined>} [param2.env] environment
    * @returns {Promise<number> & { childProcess: ChildProcess }}} promise for
    * exit status. The return result has a `childProcess` property to obtain
    * control over the running process

packages/agoric-cli/lib/start.js

@@ -1,5 +1,4 @@
 /* global process setTimeout */
-import path from 'path';
 import chalk from 'chalk';
 import { createHash } from 'crypto';
 
@@ -11,10 +10,7 @@ import {
   finishCosmosApp,
 } from './chain-config.js';
 
-import { makePspawn } from './helpers.js';
-
-const filename = new URL(import.meta.url).pathname;
-const dirname = path.dirname(filename);
+import { makePspawn, getSDKBinaries } from './helpers.js';
 
 const PROVISION_COINS = `100000000${STAKING_DENOM},50000000000${CENTRAL_DENOM},100provisionpass,100sendpacketpass`;
 const DELEGATE0_COINS = `50000000${STAKING_DENOM}`;
@@ -49,8 +45,9 @@ export default async function startMain(progname, rawArgs, powers, opts) {
 
   let keysSpawn;
   if (opts.sdk) {
+    const { cosmosHelper } = getSDKBinaries();
     keysSpawn = (args, ...rest) =>
-      pspawn('ag-cosmos-helper', [`--home=_agstate/keys`, ...args], ...rest);
+      pspawn(cosmosHelper, [`--home=_agstate/keys`, ...args], ...rest);
   } else {
     keysSpawn = (args, ...rest) =>
       pspawn(
@@ -116,7 +113,7 @@ export default async function startMain(progname, rawArgs, powers, opts) {
 
   let agSolo;
   if (opts.sdk) {
-    agSolo = path.resolve(dirname, '../../solo/src/entrypoint.js');
+    ({ agSolo } = getSDKBinaries());
   } else {
     agSolo = `ag-solo`;
   }
@@ -201,8 +198,10 @@ export default async function startMain(progname, rawArgs, powers, opts) {
 
     let chainSpawn;
     if (popts.sdk) {
-      chainSpawn = (args, spawnOpts = undefined) =>
-        pspawn('ag-chain-cosmos', [...args, `--home=${agServer}`], spawnOpts);
+      const { cosmosChain } = getSDKBinaries();
+      chainSpawn = (args, spawnOpts = undefined) => {
+        return pspawn(cosmosChain, [...args, `--home=${agServer}`], spawnOpts);
+      };
     } else {
       chainSpawn = (args, spawnOpts = undefined, dockerArgs = []) =>
         pspawn(