Skip to content

Commit 6dcd185

Browse files
committed
fix: update docs and metadata to require Node.js v13.0.1 or higher
We acquired a dependency on at least 12.11 (see #837) that we don't understand enough to relax, and we're only testing CI on 13. So we're declaring that we require Node 13 or higher. This updates the top-level package.json's `engines:` property, so that `yarn` will complain immediately if you use an old Node. It also updates a SwingSet unit test to check for the new version, as a backup. closes #937 refs #837 (makes it obsolete) closes #35
1 parent ac74538 commit 6dcd185

File tree

6 files changed

+22
-2
lines changed

6 files changed

+22
-2
lines changed

.github/workflows/ag-solo-xs.yml

+3
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ jobs:
1616

1717
steps:
1818
- uses: actions/checkout@v1
19+
- uses: actions/setup-node@v1
20+
with:
21+
node-version: '13.0.1'
1922
- name: cache node modules
2023
uses: actions/cache@v1
2124
with:

.github/workflows/integration.yml

+3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@ jobs:
2424
# restore-keys: |
2525
# ${{ runner.os }}-go-
2626

27+
- uses: actions/setup-node@v1
28+
with:
29+
node-version: '13.0.1'
2730
# 'yarn install' must be done at the top level, to build all the
2831
# cross-package symlinks
2932
- run: yarn install

.github/workflows/test-all-packages.yml

+3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ jobs:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@v1
16+
- uses: actions/setup-node@v1
17+
with:
18+
node-version: '13.0.1'
1619

1720
# FIXME: Reenable after 2020-04-01 when Github cache doesn't take forever.
1821
#- name: cache node modules

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ But if you are improving the platform itself, this is the repository to use.
99
## Prerequisites
1010

1111
* Git
12-
* Node.js (version 11 or higher)
12+
* Node.js (version 13.0.1 or higher)
1313
* Yarn (`npm install -g yarn`)
1414

1515
You don't need Golang if you just want to test contracts and run the

package.json

+3
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@
5050
"lerna": "^3.20.2",
5151
"prettier": "^1.18.2"
5252
},
53+
"engines": {
54+
"node": ">=13.0"
55+
},
5356
"scripts": {
5457
"OFF-clean": "yarn workspaces run clean",
5558
"check-dependencies": "node ./scripts/check-mismatched-dependencies.js",

packages/SwingSet/test/test-node-version.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,18 @@
33
import semver from 'semver';
44
import { test } from 'tape-promise/tape';
55

6-
test('Node version', t => {
6+
test('Node version for IO queue priority', t => {
77
t.true(
88
semver.satisfies(process.version, '>=11.0'),
99
'we need Node 11 where the IO queue is higher priority than the Promise queue',
1010
);
1111
t.end();
1212
});
13+
14+
test('Node version', t => {
15+
t.true(
16+
semver.satisfies(process.version, '>=13.0'),
17+
'we only test against Node 13',
18+
);
19+
t.end();
20+
});

0 commit comments

Comments
 (0)