Skip to content

Commit 79e81b0

Browse files
authored
fix: missing console methods (#2254)
1 parent 50c8548 commit 79e81b0

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

packages/xsnap/lib/console-shim.js

+17-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ const noop = _ => {};
1616
* Note that this runs in the start compartment,
1717
* before lockdown.
1818
*
19-
* TODO: consider other methods per SES VirtualConsole.
2019
* See https://github.com/Agoric/agoric-sdk/issues/2146
2120
*/
2221
const console = {
@@ -26,9 +25,26 @@ const console = {
2625
warn: tryPrint,
2726
error: tryPrint,
2827

28+
trace: noop,
29+
dirxml: noop,
2930
group: noop,
3031
groupCollapsed: noop,
3132
groupEnd: noop,
33+
34+
assert: noop,
35+
timeLog: noop,
36+
37+
clear: noop,
38+
count: noop,
39+
countReset: noop,
40+
dir: noop,
41+
42+
table: noop,
43+
time: noop,
44+
timeEnd: noop,
45+
profile: noop,
46+
profileEnd: noop,
47+
timeStamp: noop,
3248
};
3349

3450
globalThis.console = console;

0 commit comments

Comments
 (0)