Skip to content

Commit a761169

Browse files
warnermhofman
andcommitted
fix: drop Node.js v12 support, require v14.15.0 or higher
closes #1925 closes #837 The agoric-sdk as a whole requires/advises v14. We're leaving the individual package.jsons alone until a specific updated requirement is found for each (e.g. SwingSet will soon bump to v14 because it will require WeakRef). We won't be testing v12 support anywhere, but it's possible that individual packages will still work with v12 until we believe otherwise. Co-authored-by: Mathieu Hofman <86499+mhofman@users.noreply.github.com>
1 parent 13ce8a8 commit a761169

File tree

5 files changed

+25
-15
lines changed

5 files changed

+25
-15
lines changed

.github/workflows/ag-solo-xs.yml.DISABLED

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- uses: actions/checkout@v2
1919
- uses: actions/setup-node@v1
2020
with:
21-
node-version: '12.x'
21+
node-version: '14.x'
2222
- name: cache node modules
2323
uses: actions/cache@v1
2424
with:

.github/workflows/integration.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717

1818
- uses: actions/setup-node@v1
1919
with:
20-
node-version: '12.x'
20+
node-version: '14.x'
2121
- name: cache node modules
2222
uses: actions/cache@v1
2323
with:

.github/workflows/test-all-packages.yml

+20-11
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ jobs:
1414
runs-on: ubuntu-latest
1515
strategy:
1616
matrix:
17-
node-version: ['12.x', '14.x']
17+
# TODO: ['14.x', '16.x']
18+
node-version: ['14.x']
1819
steps:
1920
- uses: actions/checkout@v2
2021
with:
@@ -51,7 +52,8 @@ jobs:
5152
runs-on: ubuntu-latest
5253
strategy:
5354
matrix:
54-
node-version: ['12.x']
55+
# note: only use one node-version
56+
node-version: 14.x
5557
steps:
5658
- uses: actions/setup-node@v1
5759
with:
@@ -83,7 +85,7 @@ jobs:
8385
runs-on: ubuntu-latest
8486
strategy:
8587
matrix:
86-
node-version: ['14.x']
88+
node-version: 14.x
8789
if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
8890
steps:
8991
- uses: actions/setup-node@v1
@@ -122,7 +124,7 @@ jobs:
122124
runs-on: ubuntu-latest
123125
strategy:
124126
matrix:
125-
node-version: ['14.x']
127+
node-version: 14.x
126128
if: ${{github.event_name == 'push' && github.ref == 'refs/heads/master'}}
127129
steps:
128130
- uses: actions/setup-node@v1
@@ -177,7 +179,8 @@ jobs:
177179
runs-on: ubuntu-latest
178180
strategy:
179181
matrix:
180-
node-version: ['12.x', '14.x']
182+
# TODO: ['14.x', '16.x']
183+
node-version: ['14.x']
181184
steps:
182185
- uses: actions/setup-node@v1
183186
with:
@@ -306,7 +309,8 @@ jobs:
306309
runs-on: ubuntu-latest
307310
strategy:
308311
matrix:
309-
node-version: ['12.x', '14.x']
312+
# TODO: ['14.x', '16.x']
313+
node-version: ['14.x']
310314
steps:
311315
- uses: actions/setup-node@v1
312316
with:
@@ -372,7 +376,8 @@ jobs:
372376
runs-on: ubuntu-latest
373377
strategy:
374378
matrix:
375-
node-version: ['12.x', '14.x']
379+
# TODO: ['14.x', '16.x']
380+
node-version: ['14.x']
376381
steps:
377382
- uses: actions/setup-node@v1
378383
with:
@@ -410,7 +415,8 @@ jobs:
410415
runs-on: ubuntu-latest
411416
strategy:
412417
matrix:
413-
node-version: ['12.x', '14.x']
418+
# TODO: ['14.x', '16.x']
419+
node-version: ['14.x']
414420
steps:
415421
- uses: actions/setup-node@v1
416422
with:
@@ -457,7 +463,8 @@ jobs:
457463
runs-on: ubuntu-latest
458464
strategy:
459465
matrix:
460-
node-version: ['12.x', '14.x']
466+
# TODO: ['14.x', '16.x']
467+
node-version: ['14.x']
461468
steps:
462469
- uses: actions/setup-node@v1
463470
with:
@@ -502,7 +509,8 @@ jobs:
502509
runs-on: ubuntu-latest
503510
strategy:
504511
matrix:
505-
node-version: ['12.x', '14.x']
512+
# TODO: ['14.x', '16.x']
513+
node-version: ['14.x']
506514
steps:
507515
- uses: actions/setup-node@v1
508516
with:
@@ -540,7 +548,8 @@ jobs:
540548
runs-on: ubuntu-latest
541549
strategy:
542550
matrix:
543-
node-version: ['14.x']
551+
# note: only use one node-version, maybe
552+
node-version: 14.x
544553
steps:
545554
- uses: actions/setup-node@v1
546555
with:

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ to use.
1717
## Prerequisites
1818

1919
* Git
20-
* Node.js (version 12.14.1 or higher)
20+
* Node.js LTS (version 14.15.0 or higher)
21+
* we generally support the latest LTS release: use [nvm](https://github.com/nvm-sh/nvm) to keep your local system up-to-date
2122
* Yarn (`npm install -g yarn`)
2223

2324
Any version of Yarn will do: the `.yarnrc` file should ensure that all

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"typescript": "^4.2.3"
6464
},
6565
"engines": {
66-
"node": ">=12.14.1"
66+
"node": ">=14.15.0"
6767
},
6868
"scripts": {
6969
"OFF-clean": "yarn workspaces run clean",

0 commit comments

Comments
 (0)