-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmos-level governance for swingset metering+fee parameters #3752
Comments
FYI, @michaelfig |
In addition to the computrons-per-block parameter, we want to make parameters for charging for messages inbound to (JS-level) swingset. There will be a charge per message, plus a charge per byte, plus a charge per slot. These charges should also be subject to modification via (Cosmos-level) governance. Also need to wire up the actual use of these charge parameters. There is one entry point in Eventually, the message fee parameters will be added to the message as metadata so that they can be applied so inter-vat messages at the JS level. |
Thanks, looks good. Just a different starting default:
I think for this issue to be fixed, the fees should be transferred (not minted) to |
What is the Problem Being Solved?
Like #3665, we'd like to be able to modify the
x/swingset
parameters through Cosmos-level governance. Currently there are no parameters in this module, so we'd like to addmax_computrons_per_block
as a parameter.Description of the Design
The entire set of
x/swingset
parameters should be sent to JS in theendBlockAction
message byEndBlock()
ingolang/cosmos/x/swingset/abci.go
. A reasonable default values is 8,000,000.A second PR can have JS interpret this new field in the
endBlockAction
message.Security Considerations
We need to be sure a bad value won't be able to prevent a corrective change. Fortunately, even a setting as low as zero won't prevent further action at the Cosmos level. We might consider an upper limit, though.
Test Plan
Unit tests, then we expect to try it out on the test network to tune it.
The text was updated successfully, but these errors were encountered: