Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make VaultFactory reachably durable #5285

Closed
turadg opened this issue May 4, 2022 · 2 comments
Closed

Make VaultFactory reachably durable #5285

turadg opened this issue May 4, 2022 · 2 comments
Assignees
@turadg
Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Milestone
Vaults EVP

Comments

@turadg
Copy link
Member

turadg commented May 4, 2022 •
edited
Loading

What is the Problem Being Solved?

#5736 made Vault Factory sort of durable, but it has some hacks around #4567 and it's not yet reachably durable .

For the next release we need it to be not just reachably durable, but upgradable: #6791

Description of the Design

Store everything precious.

Security Considerations

State on disk.

Test Plan

Manual review that all precious state is stored.
@turadg turadg added enhancement New feature or request Inter-protocol Overarching Inter Protocol labels May 4, 2022
@dtribble
Copy link
Member

dtribble commented May 4, 2022

A simpler solution in this case: upon upgrade I would expect to restart the liquidator activity, which is the loop waiting for the quote promise to be resolved. Basically, liquidationInProgress and outstandingQuote need to be made ephemeral.

@Tartuffo Tartuffo added this to the Mainnet 1 milestone May 5, 2022
@Tartuffo Tartuffo modified the milestone: Mainnet 1 May 13, 2022
@turadg turadg mentioned this issue Jul 7, 2022
Merged
@turadg turadg changed the title Make vaultManager durable Make vaultManager reachably durable Jul 20, 2022
@turadg turadg changed the title Make vaultManager reachably durable Make VaultFactory reachably durable Jul 22, 2022
@Tartuffo Tartuffo removed this from the Mainnet 1 RC0 milestone Sep 21, 2022
@ivanlei ivanlei added the vaults_triage DO NOT USE label Jan 4, 2023
This was referenced Jan 10, 2023
Merged
Merged
@turadg turadg changed the title Make VaultFactory reachably durable make the VaultFactory contract upgradable Jan 14, 2023
@turadg turadg changed the title make the VaultFactory contract upgradable Make VaultFactory reachably durable Jan 14, 2023
This was referenced Jan 27, 2023
Merged
Closed
Closed
@ivanlei ivanlei added this to the Vaults RC0 milestone Feb 1, 2023
@rowgraus rowgraus modified the milestones: Vaults RC0, Vaults EVP Feb 3, 2023
@ivanlei ivanlei removed the MUST-HAVE label Mar 20, 2023
@turadg
Copy link
Member Author

turadg commented Mar 20, 2023

I think this has been done a while, actually.

@turadg turadg closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

Labels
enhancement New feature or request Inter-protocol Overarching Inter Protocol vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults EVP
Development

No branches or pull requests
5 participants
@turadg @Tartuffo @dtribble @ivanlei @rowgraus