-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample HDR image looks too bright in Thorium v117 #18
Comments
@o-l-a-v I updated it to 0.9.0 in the M120 version. Can you test? |
Thanks, will test tomorrow if I remember it. :) |
@o-l-a-v Nothing more I can do, as I cannot update the libjxl library past 0.9.0. They removed some stuff that it critical for integrating into blink in 0.9.1. Im sorry. |
What was removed that was critical for integrating into blink? |
The deleted things are here. We modified the code based on the patches provided by Google engineers, and the version numbers are consistent with those used by Google engineers. |
How are any of those things critical? Most of them are encoder settings, except for |
@Traneptora @o-l-a-v @gz83 We fixed it, as they fixed it upstream. Now we are using libhighway 1.0.7, and libjxl 0.9.2. |
@o-l-a-v @Traneptora Can you try the M121 version and report back |
They still don't look the same. |
0.9.2 is the latest publicly released version. If you still cannot get the expected results, there may be other factors affecting it. |
Sure, but that's out of my knowledge. Thorium devs say "We fixed it, as they fixed it upstream." without even trying the test image in this issue original post apperently. Maybe @Traneptora or JXL devs have more knowledge about what causes this. |
@o-l-a-v Dang, I'm sorry. No I didn't test, I just assumed it would fix it since 0.9.1 (and hence 0.9.2), is supposed to fix HDR issues. |
No worries @Alex313031, I also understand that this could be out of your/Thorium's control. :) |
Here's an image that looks too bright in Thorium v117.0.5938.157 (Official Build) (64-bit):
Found here:
Here's a screenshot:
The text was updated successfully, but these errors were encountered: