Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved search in the Terminal #5417

Closed
imcasper opened this issue Sep 4, 2021 · 1 comment
Closed

Improved search in the Terminal #5417

imcasper opened this issue Sep 4, 2021 · 1 comment

Comments

@imcasper
Copy link

imcasper commented Sep 4, 2021

Describe the feature
Fuzzy search.
For example, one letter out "Iron re". It is unlikely that the person was looking not "Iron ore".
It is also convenient to search by capital letters (and some first char):
"IrOr" -- pattern for "IrOr" (iron ore and may be Irridium Ornament, etc.)
"SI" -- pattern for "S*I" (steel ingot and not only)

Reasons why it should be considered
Its more comfortable for search in complex mod... For example:
GenFlu -- Generator Fluid
GenSo -- Generator solar
WoD -- wooden door
etc.

Additional Context

@yueh
Copy link
Contributor

yueh commented Sep 12, 2021

Similar to other more advanced search options, it is not reallly feasible in terms of performance. We do not have the luxury like JEI to take 10-15 seconds to build a sophisticated search tree once every time a world is loaded. Instead we had to do it each time a terminal is opened. Taking into account that the network inventory is dynamic and can constantly change, has to deal with custom item names and similar.

Having to backtrack parts of the search query can be quite costly. Especially as it will scale at least linearly with the amount of stored items (or probably worse). We already had issues in the past of having the search in which it would get stuck for a few seconds after each keypress until it finally filtered all items and updated the view.

So for now it is not really an option due to performance problems.

@yueh yueh closed this as completed Sep 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants