Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid somehow got into my inventory as an item. #8406

Open
Cosmoros-git opened this issue Feb 26, 2025 · 7 comments
Open

Fluid somehow got into my inventory as an item. #8406

Cosmoros-git opened this issue Feb 26, 2025 · 7 comments
Labels
awaiting-feedback Waiting on feedback from the author. Issue will be closed after 7 days of inactivity. bug Self explanatory?

Comments

@Cosmoros-git
Copy link

Describe the bug

Was using GT drums to drop fluid into the network inside the AE interface. Somehow got this to happen.

Image

Thats aint right. Also fluid is real, not visual.

Monifactory Modpack.

How to reproduce the bug

Shift right-click with a drum inside the Interface bottom area.

Expected behavior

Not happen?

Additional details

https://mclo.gs/dVM2D8n Client Log

latest.log Server log

Which minecraft version are you using?

1.20

On which mod loaders does it happen?

Forge

Crash log

None

@Cosmoros-git Cosmoros-git added the bug Self explanatory? label Feb 26, 2025
@Cosmoros-git Cosmoros-git changed the title Fluid somehow got into my storaga as an item. Fluid somehow got into my inventory as an item. Feb 26, 2025
@paperky
Copy link

paperky commented Feb 27, 2025

Something that might help debugging is if you can pick up/still have the items, you can force a crash by holding f3+c for a ~10 seconds; might give more info than the no-crash client log you uploaded.

Also on the steps to reproduce, can you clarify? There's a few details missing else I'd make a guess.
Does turning on advanced tooltips (F3+H) give any additional information when hovering the fluid items?

@Cosmoros-git
Copy link
Author

Sadly cannot see if the tags were special or not. However, the liquid behaved exactly as it would in the AE interface.

IMO it appeared that somehow interface got confused about where to place the liquids it imported and decided to use my inventory for it. I am unsure if I managed to duplicate liquids by using drums to suck them out of my inventory or just was being provided with the liquids from AE.

Sadly I got rid of the items due to GT inventory storage being already a pain, with 2 slots gone for bugged items wasn't a great idea.

I would try to narrate exactly what I did.

  1. Picked up liquids from the Assembler into the barrel.
  2. Wanted to dump it into the interface above the assembler (the interface might have been midway through filling the assembler so in action)
  3. Started shift + right-clicking to dump liquid quite fast. In the 4th interface bottom slot (might have somehow got my liquid back inside leading to my inventory being the interface valid)
  4. Got the liquids to teleport into my inventory, one occupied my hand and the other occupied free storage space if we go by left to right filling.

My suspicions are that somehow interface getting linked to my inventory while I was connected because I got the liquid out of it fast enough to get it but slow enough for the game to remember where the liquid was and get connected to my inventory.

@Cosmoros-git
Copy link
Author

Image

And it´s me again, and I got to repeat this bug.

I did the same thing. just spammed the drum with fluids into the system while the interface supplied liquids to a machine.

Image
This time, tho, I took a look. it has no NBT data, nothing. And on the item frame, it's displayed as a generic wrapper.

@shartte
Copy link
Member

shartte commented Mar 1, 2025

Yes it is a generic wrapper and no, you should not be able to extract this from an inventory.
But what do you mean "just spammed the drum with fluids into the system".
can you explain the UI interactions you did step by step?

@Cosmoros-git
Copy link
Author

Yes it is a generic wrapper and no, you should not be able to extract this from an inventory. But what do you mean "just spammed the drum with fluids into the system". can you explain the UI interactions you did step by step?

I was making GT energy hatches and had to provide Sodium Potassium liquid to the assembler. However, the assembler previously had a different liquid I was dumping back into the system.

I simply opened the interface and was spam clicking to dump the drum of liquid into the system. As mentioned, I suspect that somehow the interface gets confused about its inventory and player inventory if you try placing/picking liquids really fast when it's filling it. I will try to capture the thing on video.

@shartte
Copy link
Member

shartte commented Mar 3, 2025

Yes it is a generic wrapper and no, you should not be able to extract this from an inventory. But what do you mean "just spammed the drum with fluids into the system". can you explain the UI interactions you did step by step?

I was making GT energy hatches and had to provide Sodium Potassium liquid to the assembler. However, the assembler previously had a different liquid I was dumping back into the system.

I simply opened the interface and was spam clicking to dump the drum of liquid into the system. As mentioned, I suspect that somehow the interface gets confused about its inventory and player inventory if you try placing/picking liquids really fast when it's filling it. I will try to capture the thing on video.

The details are important. What do you mean by spam clicking. Shift-clicking on a fluid container (drum) in your player inventory while the UI of an ME interface is open? Or did you hold the drum in-hand in the inventory and right-click the interface slot?

@Technici4n Technici4n added the awaiting-feedback Waiting on feedback from the author. Issue will be closed after 7 days of inactivity. label Mar 6, 2025
@Cosmoros-git
Copy link
Author

The details are important. What do you mean by spam clicking. Shift-clicking on a fluid container (drum) in your player inventory while the UI of an ME interface is open? Or did you hold the drum in-hand in the inventory and right-click the interface slot

I was shift-clicking the fluid container (Drum) in the interface to empty it from fluid, which led to me getting liquid inside my inventory. It's quite random and so far didn't get it to repeat, mostly due to not needing to do that anymore.

Steps:

  1. Drum with liquid.
  2. Interface in the process of filling something.
  3. Open the interface and start dumping liquid from the drum.
  4. If you get it to happen at the same time the interface is filling itself, the liquid gets into your inventory.
  5. Also, it could be me picking the liquid on the same tick as I deposit it, leading to interface considering my inventory as his.

I would look into functions that deal with passing the liquid into the interface and how it counts what's valid inventory and if it can somehow get 2 inventories as valid at once from one interface.

Or the one that relates to emptying the liquid from the interface storage into the ME system. How it detects where the liquid is and how it points to the inventory. It could register the liquid it wants to get into the system, and when it's picked by the player, it gets referenced to the player's inventory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-feedback Waiting on feedback from the author. Issue will be closed after 7 days of inactivity. bug Self explanatory?
Projects
None yet
Development

No branches or pull requests

4 participants