fix: harden post type check to prevent notices

claudiulodro · claudiulodro · commit 60879a9ce83d · 2020-09-02T11:00:24.000-07:00
diff --git a/includes/class-newspack-sponsors-editor.php b/includes/class-newspack-sponsors-editor.php
@@ -99,8 +99,7 @@ public static function disable_yoast_primary_category_picker( $taxonomies, $post
 	 * Is editing a sponsor?
 	 */
 	public static function is_editing_sponsor() {
-		$post_type = get_post()->post_type;
-		return Core::NEWSPACK_SPONSORS_CPT === $post_type;
+		return Core::NEWSPACK_SPONSORS_CPT === get_post_type();
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,7 @@ public static function disable_yoast_primary_category_picker( $taxonomies, $post`
`99`	`99`	`* Is editing a sponsor?`
`100`	`100`	`*/`
`101`	`101`	`public static function is_editing_sponsor() {`
`102`		`- $post_type = get_post()->post_type;`
`103`		`- return Core::NEWSPACK_SPONSORS_CPT === $post_type;`
	`102`	`+ return Core::NEWSPACK_SPONSORS_CPT === get_post_type();`
`104`	`103`	`}`
`105`	`104`
`106`	`105`	`/**`